[OE-core] [PATCH 3/5] bbpath-intercepts.bbclass: add class

[Christopher Larson]

On Fri, Jun 22, 2018 at 12:42 AM Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:

> On Fri, 2018-06-22 at 02:08 +0500, Christopher Larson wrote:
> > From: Christopher Larson <chris_larson at mentor.com>
> >
> > This class sets POSTINST_INTERCEPTS and
> > POSTINST_INTERCEPTS_CHECKSUMS,
> > to allow us to pull intercepts from BBPATH. This is kept as a
> > separate
> > class, as it's needed by both image construction and sdk
> > construction,
> > the latter to support meta-toolchain & similar recipes.
> >
> > Signed-off-by: Christopher Larson <chris_larson at mentor.com>
> > ---
> >  meta/classes/bbpath-intercepts.bbclass | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100644 meta/classes/bbpath-intercepts.bbclass
>
> We're struggling a bit with classes and namespaces. I'm wondering if
> this might be better as "image-postinst-intercepts.bbclass" or similar.
> That would mean the variable namespace matches the class and that the
> image classes are more 'together'.
>
> Your next patch will need rebasing against the changes that just merged
> into master in image.bbclass.
>
> I have also wondered about pushing more code to lib/oe but I can see
> why this makes sense as a bbclass.
>

Yeah, I think in this case this works as a class, but you're right, we
should probably shift more to the python package. Namespacing is probably a
good idea, we've talked about doing that more in the past. In this case
it's technically not image-only, though an sdk uses the same underlying
functionality, so it's debatable. I wonder if we should namespace into a
subdirectory to also make it easier to make sense of classes/ at a
command-line, i.e. inherit image/postinst-intercepts.bbclass? Hmmm.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180622/66bb218d/attachment-0002.html>