[OE-core] [PATCH] qemu: Use capstone version included via git submodule

[Bruce Ashfield]

On Mon, Jun 25, 2018 at 1:50 PM, Jon Szymaniak <jon.szymaniak.foss at gmail.com
> wrote:

> An optional dependency upon the capstone disassembler was introduced
> in QEMU v2.11.0-rc0. The necessary version of capstone is included
> in the QEMU repository as a git submodule.
>
> The QEMU configure script uses pkg-config to determine if an
> installation of capstone already exists on the system, and defaults to
> this, if found. However, there does not appear to be any capstone
> version or API compatibility checks.
>
> To avoid any potential version conflicts or API incompatibility issues
> in the future, use the `--enable-capstone=git` argument to force the use
> of the capstone version included by QEMU as a git submodule.
>

How exactly does that work when the default qemu recipe is a tar.bz2
download ?

We can't have the recipe going out to the 'net and fetching / downloading
source code .. and looking at the option, that appears to be what it would
do. Or maybe I'm missing where the code is being fetched into place.

This is something that looks like it could be controlled via packageconfig,
or similar mechanism, versus being hard coded into the configure line.

Also, the patch is missing your Signed-off-by:

Cheers,

Bruce


> ---
>  meta/recipes-devtools/qemu/qemu.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-devtools/qemu/qemu.inc
> b/meta/recipes-devtools/qemu/qemu.inc
> index 094a975177..37f8398967 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -23,6 +23,7 @@ EXTRA_OECONF = " \
>      --libexecdir=${libexecdir} \
>      --localstatedir=${localstatedir} \
>      --with-confsuffix=/${BPN} \
> +    --enable-capstone=git \
>      --disable-strip \
>      --disable-werror \
>      --target-list=${@get_qemu_target_list(d)} \
> --
> 2.14.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180625/16c3355d/attachment-0002.html>