[OE-core] [OE-Core][PATCH 1/2] image: Set COREBASE as the git directory for timestamp

[Christopher Larson]

On Thu, Jun 28, 2018 at 8:29 AM Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:

> On Thu, 2018-06-28 at 15:18 +0000, Peter Kjellerstedt wrote:
> > There is no guarantee that ${COREBASE} refers to a path that is
> > under Git control. E.g., in our case it refers to a directory that is
> > under repo control. "${COREBASE}/meta" is probably a better option.
>
> You could make that argument about /meta too.
>
> I'd suggest the code checks for ${COREBASE}/.git and if that doesn't
> exist, fall back to the timestamp of the
> ${COREBASE}/meta/conf/bitbake.conf file.
>

That's a good idea, but I'd suggest using bb.utils.which() to locate
conf/bibake.conf rather than hardcoding that path.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180628/6c68a939/attachment-0002.html>