[OE-core] [PATCH v3 00/13] go1.10 update and misc improvements

Khem Raj raj.khem at gmail.com
Fri Mar 2 06:10:14 UTC 2018


On Thu, Mar 1, 2018 at 9:43 PM, Khem Raj <raj.khem at gmail.com> wrote:
>
>
> On 3/1/18 3:16 PM, Matt Madison wrote:
>>
>> New in v3:
>>      * reduced one of the go source patches,
>>        eliminating an unneeded change (thanks
>>        Otavio)
>>      * Added bbclass and recipe patches to
>>        handle SECURITY_CFLAGS settings if
>>        they're enabled
>>      * Added go-runtime-staticdev to target-side
>>        SDK, needed for go static builds (fixes
>>        test case failure in oe-selftest)
>>      * two more minor cleanups
>>
>> New in v2:
>>      * Fixed Upstream-Status line in go patches
>>      * Added GOTMPDIR to do_configure[dirs]
>>
>> Updates to the go recipes and bbclasses for go1.10, which
>> moves the bulk of the toolchain bootstrap and build out
>> of the 'make.bash' script and to the 'dist' tool.  This
>> required a rework of the patches to the go source.
>>
>> go1.10 introduces significant changes to the go build
>> tool as well, requiring some further patches to make
>> it work for OE builds.
>
>
> The errors from v2 are gone but here I am seeing another error in
> meta-influx with this patchset with ptest enabled
>
> DISTRO_FEATURES_append = " ptest"
>
>
> bitbake github.com-eapache-go-xerial-snappy
>

for github.com-alicebob-miniredis you dont even need to ptest enabled

>
> | DEBUG: Executing shell function do_compile_ptest_base
> | go build github.com/golang/snappy: missing or invalid GOROOT-resident
> package
> | WARNING:
> /mnt/a/zonit/build/tmp/work/aarch64-bec-linux/github.com-eapache-go-xerial-snappy/1.0-r0/temp/run.do_compile_ptest_base.21897:1
> exit 1 from 'go_list_package_tests'
>
> This error seems to be due to a patch
> 0007-cmd-go-make-GOROOT-precious-by-default.patch
>
> It worked fine with 1.9
>
>
>>
>> See https://golang.org/doc/go1.10 for a complete list
>> of new features and changes.
>>
>> Following the update are some cleanup/improvement
>> patches.
>>
>> Matt Madison (13):
>>    go: update go 1.9 -> go 1.10
>>    go: set GOMIPS envrionment variable
>>    go.bbclass: rename GO_TMPDIR -> GOTMPDIR
>>    go.bbclass: remove debug-related commands
>>    go.bbclass: don't stage test data with sources
>>    go.bbclass: ptest cleanup and improvements
>>    goarch.bbclass: disable shared runtime for nativesdk builds
>>    go: move common settings to go-common.inc
>>    go.bbclass, goarch.bbclass: update SECURITY_CFLAGS
>>    go: disable PIE CFLAGS for nativesdk and cross-canadian builds
>>    packagegroup-go-sdk-target: add go-runtime-staticdev
>>    go-runtime: remove unneeded nativesdk override, rename variable
>>    go-cross-canadian: remove verbosity setting from GO_LDFLAGS
>>
>>   meta/classes/go.bbclass                            | 108 ++++----
>>   meta/classes/goarch.bbclass                        |  13 +
>>   .../packagegroups/packagegroup-go-sdk-target.bb    |   1 +
>>   meta/recipes-devtools/go/go-1.10.inc               |  21 ++
>>   ...1-allow-CC-and-CXX-to-have-multiple-words.patch |  33 +++
>>   ...-content-based-hash-generation-less-pedan.patch | 220
>> ++++++++++++++++
>>   ...OLDIR-to-be-overridden-in-the-environment.patch |  64 +++++
>>   .../0004-ld-add-soname-to-shareable-objects.patch  |  47 ++++
>>   ...verride-CC-when-building-dist-and-go_boot.patch |  40 +++
>>   ...-cmd-dist-separate-host-and-target-builds.patch | 277
>> +++++++++++++++++++++
>>   ...07-cmd-go-make-GOROOT-precious-by-default.patch |  97 ++++++++
>>   ...ld-replace-glibc-dynamic-linker-with-musl.patch | 130 ++++++++++
>>   meta/recipes-devtools/go/go-1.9.inc                |  26 --
>>   .../0001-make.bash-quote-CC_FOR_TARGET.patch       |  32 ---
>>   ...CC-and-CXX-environment-variable-construct.patch |  67 -----
>>   ...sh-better-separate-host-and-target-builds.patch |  92 -------
>>   ...w-GOTOOLDIR-to-be-overridden-in-the-envir.patch |  68 -----
>>   ...05-cmd-go-make-GOROOT-precious-by-default.patch |  41 ---
>>   ...dd-GOTOOLDIR_BOOTSTRAP-environment-variab.patch |  36 ---
>>   .../0007-ld-add-soname-to-shareable-objects.patch  |  46 ----
>>   ...dd-GOHOSTxx-indirection-for-cross-canadia.patch |  33 ---
>>   ...dmode-pie-forces-external-linking-mode-on.patch |  47 ----
>>   ...verride-CC-when-building-dist-and-go_boot.patch |  43 ----
>>   .../go/go-1.9/set-external-linker.patch            | 111 ---------
>>   meta/recipes-devtools/go/go-common.inc             |   6 +
>>   meta/recipes-devtools/go/go-cross-canadian.inc     |  26 +-
>>   ...s-canadian_1.9.bb => go-cross-canadian_1.10.bb} |   0
>>   meta/recipes-devtools/go/go-cross.inc              |  56 ++---
>>   .../go/{go-cross_1.9.bb => go-cross_1.10.bb}       |   0
>>   meta/recipes-devtools/go/go-crosssdk.inc           |  14 +-
>>   .../go/{go-crosssdk_1.9.bb => go-crosssdk_1.10.bb} |   0
>>   meta/recipes-devtools/go/go-native.inc             |  25 +-
>>   .../go/{go-native_1.9.bb => go-native_1.10.bb}     |   0
>>   meta/recipes-devtools/go/go-runtime.inc            |  56 ++---
>>   .../go/{go-runtime_1.9.bb => go-runtime_1.10.bb}   |   0
>>   meta/recipes-devtools/go/go-target.inc             |  24 +-
>>   meta/recipes-devtools/go/{go_1.9.bb => go_1.10.bb} |   0
>>   37 files changed, 1095 insertions(+), 805 deletions(-)
>>   create mode 100644 meta/recipes-devtools/go/go-1.10.inc
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0001-allow-CC-and-CXX-to-have-multiple-words.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0002-cmd-go-make-content-based-hash-generation-less-pedan.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0003-allow-GOTOOLDIR-to-be-overridden-in-the-environment.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0004-ld-add-soname-to-shareable-objects.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0005-make.bash-override-CC-when-building-dist-and-go_boot.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0006-cmd-dist-separate-host-and-target-builds.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0007-cmd-go-make-GOROOT-precious-by-default.patch
>>   create mode 100644
>> meta/recipes-devtools/go/go-1.10/0008-ld-replace-glibc-dynamic-linker-with-musl.patch
>>   delete mode 100644 meta/recipes-devtools/go/go-1.9.inc
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0001-make.bash-quote-CC_FOR_TARGET.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0002-cmd-go-fix-CC-and-CXX-environment-variable-construct.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0003-make.bash-better-separate-host-and-target-builds.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0004-cmd-go-allow-GOTOOLDIR-to-be-overridden-in-the-envir.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0005-cmd-go-make-GOROOT-precious-by-default.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0006-make.bash-add-GOTOOLDIR_BOOTSTRAP-environment-variab.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0007-ld-add-soname-to-shareable-objects.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0008-make.bash-add-GOHOSTxx-indirection-for-cross-canadia.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0009-cmd-go-buildmode-pie-forces-external-linking-mode-on.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/0010-make.bash-override-CC-when-building-dist-and-go_boot.patch
>>   delete mode 100644
>> meta/recipes-devtools/go/go-1.9/set-external-linker.patch
>>   rename meta/recipes-devtools/go/{go-cross-canadian_1.9.bb =>
>> go-cross-canadian_1.10.bb} (100%)
>>   rename meta/recipes-devtools/go/{go-cross_1.9.bb => go-cross_1.10.bb}
>> (100%)
>>   rename meta/recipes-devtools/go/{go-crosssdk_1.9.bb =>
>> go-crosssdk_1.10.bb} (100%)
>>   rename meta/recipes-devtools/go/{go-native_1.9.bb => go-native_1.10.bb}
>> (100%)
>>   rename meta/recipes-devtools/go/{go-runtime_1.9.bb =>
>> go-runtime_1.10.bb} (100%)
>>   rename meta/recipes-devtools/go/{go_1.9.bb => go_1.10.bb} (100%)
>>
>



More information about the Openembedded-core mailing list