[OE-core] [PATCH 02/29] dbus-glib: refresh patch

[Burton, Ross]

I was about to write a long email explaining all this but my dinner is
almost ready.

Short version: patch fuzz is dangerous, we've had patches apply using fuzz
which actually break the code, or doing something else stupid like repeat a
statement.

We'd like to eventually have do_patch rejecting any fuzz on these grounds,
so I wrote a nasty script to rebase all the patches and am reviewing them
bit by bit.  Note that two of these patches are deleting patches that we've
been applying although upstream have already applied the same fix...

Ross

On 5 March 2018 at 17:24, akuster808 <akuster808 at gmail.com> wrote:

>
>
> On 03/05/2018 09:20 AM, Ross Burton wrote:
> > Signed-off-by: Ross Burton <ross.burton at intel.com>
>
> Why do this patches need to be refreshed?
>
> - armin
> > ---
> >  meta/recipes-core/dbus/dbus-glib/no-examples.patch | 10 ++++++----
> >  1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/meta/recipes-core/dbus/dbus-glib/no-examples.patch
> b/meta/recipes-core/dbus/dbus-glib/no-examples.patch
> > index fbb49678282..32e76117188 100644
> > --- a/meta/recipes-core/dbus/dbus-glib/no-examples.patch
> > +++ b/meta/recipes-core/dbus/dbus-glib/no-examples.patch
> > @@ -5,11 +5,13 @@ Upstream-Status: Inappropriate [disable feature]
> >  Signed-off-by: Kevin Tian <kevin.tian at intel.com>
> >  Signed-off-by: Scott Garman <scott.a.garman at intel.com>
> >
> > ---- dbus-glib-0.70/dbus/Makefile.am.orig     2006-07-23
> 16:04:43.000000000 +0200
> > -+++ dbus-glib-0.70/dbus/Makefile.am  2006-07-23 16:04:52.000000000
> +0200
> > +Index: dbus-glib-0.108/dbus/Makefile.am
> > +===================================================================
> > +--- dbus-glib-0.108.orig/dbus/Makefile.am
> > ++++ dbus-glib-0.108/dbus/Makefile.am
> >  @@ -1,4 +1,4 @@
> >  -SUBDIRS = . examples
> >  +SUBDIRS = .
> >
> > - INCLUDES=-I$(top_srcdir) $(DBUS_CFLAGS) $(DBUS_GLIB_CFLAGS)
> $(DBUS_GLIB_TOOL_CFLAGS) -DDBUS_COMPILATION=1 -DDBUS_LOCALEDIR=\"$(prefix)/@
> DATADIRNAME@/locale\"
> > -
> > + AM_CPPFLAGS = \
> > +     -I$(top_srcdir)                                         \
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180305/5193864b/attachment-0002.html>