[OE-core] [PATCH v3 07/21] grub-efi*.bbclass: don't reference vmlinuz

Andre McCurdy armccurdy at gmail.com
Tue Mar 6 01:23:58 UTC 2018


On Mon, Mar 5, 2018 at 5:00 PM, Cal Sullivan
<california.l.sullivan at intel.com> wrote:
> On 03/05/2018 04:50 AM, Burton, Ross wrote:
> On 1 March 2018 at 02:15, California Sullivan
> <california.l.sullivan at intel.com> wrote:
>>
>> +KERNEL_IMAGETYPE ??= "bzImage"
>
> You repeat this line in several classes, can we just move the default to
> default-distrovars or similar?
>
> I was trying to avoid adding to bitbake.conf (or things it inherits from)
> but I think it makes sense here. With the changes switching away from
> assuming "vmlinuz" and instead using KERNEL_IMAGETYPE, we now rely on it
> being set in a number of places, so setting a global default would be best.
> If I have your blessings I can make that change.

Isn't KERNEL_IMAGETYPE now deprecated in favour of KERNEL_IMAGETYPES?

If so, everywhere that's now referencing KERNEL_IMAGETYPE should
probably be updated to parse and deal with the list of types in
KERNEL_IMAGETYPES so that the legacy variable can eventually be
removed.



More information about the Openembedded-core mailing list