[OE-core] [morty][PATCH] lib/oe/terminal.py: use an absolute path to execute oe-gnome-terminal-phonehome

[Andre McCurdy]

On Wed, Feb 21, 2018 at 1:40 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
> On Tue, Jan 23, 2018 at 12:16 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>> On Tue, Dec 5, 2017 at 5:35 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>>> From: Ming Liu <liu.ming50 at gmail.com>
>>>
>>> A flaw was found on my Ubuntu 14.04.5 LTS, on which that gnome-terminal is
>>> the default terminal, when I run any of the tasks:
>>> bitbake busybox -c menuconfig/devshell/devpyshell
>>> bitbake virtual/kernel -c menuconfig/devshell/devpyshell
>>>
>>> I got a error as follows:
>>> "Failed to execute child process "oe-gnome-terminal-phonehome" (No such file or directory)"
>>>
>>> Seems the environment of the process calling Popen is not passed to the
>>> child process, this behaviour is a known issue in Python bug tracker:
>>> http://bugs.python.org/issue8557
>>>
>>> It could be fixed by using an absolute path instead per test.
>>
>> Ping.
>
> Ping again.

And again...

It looks like this (and a couple of other patches) made it as far as:

  http://git.openembedded.org/openembedded-core-contrib/log/?h=stable/morty-next

but then got stuck or forgotten?

>>> Signed-off-by: Ming Liu <liu.ming50 at gmail.com>
>>> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>>> (cherry picked from commit 2117c148ef07d84bc605768e3b3671b0126b9337)
>>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>>> ---
>>>  meta/lib/oe/terminal.py | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/lib/oe/terminal.py b/meta/lib/oe/terminal.py
>>> index 3c8ef59..df4c75b 100644
>>> --- a/meta/lib/oe/terminal.py
>>> +++ b/meta/lib/oe/terminal.py
>>> @@ -67,7 +67,7 @@ class Gnome(XTerminal):
>>>          import tempfile
>>>          pidfile = tempfile.NamedTemporaryFile(delete = False).name
>>>          try:
>>> -            sh_cmd = "oe-gnome-terminal-phonehome " + pidfile + " " + sh_cmd
>>> +            sh_cmd = bb.utils.which(os.getenv('PATH'), "oe-gnome-terminal-phonehome") + " " + pidfile + " " + sh_cmd
>>>              XTerminal.__init__(self, sh_cmd, title, env, d)
>>>              while os.stat(pidfile).st_size <= 0:
>>>                  continue
>>> --
>>> 1.9.1
>>>