[OE-core] [PATCH 7/8] populate_sdk_ext.bbclass: remove the try...finally

Richard Purdie richard.purdie at linuxfoundation.org
Tue Mar 13 14:57:09 UTC 2018


On Tue, 2018-03-13 at 11:24 +0800, Robert Yang wrote:
> The "sdkbasepath + '/conf/local.conf.bak" doesn't exist when
> "oe.copy_buildsystem.check_sstate_task_list()" fails, then
> os.replace() would
> raise FileNotFoundError, which overcomes the real error. Keep the
> error status
> makes debug easier, so remove the try..finally.

I don't think this patch is quite right. If there is a failure we
*must* make sure local.conf is restored, that is important. The code
should probably keep the try/finally but make the replace conditional
on the file existing.

Cheers,

Richard



More information about the Openembedded-core mailing list