[OE-core] [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

On 03/16/2018 11:38 AM, Andre McCurdy wrote:
> On Fri, Mar 16, 2018 at 3:13 AM, Burton, Ross <ross.burton at intel.com> wrote:
>> Picked to mut, thanks Cal
>>
>> Ross
>>
>> On 15 March 2018 at 19:42, Cal Sullivan <california.l.sullivan at intel.com>
>> wrote:
>>> Ping. This is still an issue and it looks like this patch fell through the
>>> cracks!
>>>
>>> Thanks,
>>> Cal
>>>
>>>
>>> On 01/24/2018 07:12 PM, California Sullivan wrote:
>>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>>
>>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>>
>>>> This breaks our menuconfig, because it can no longer find ncurses if its
>>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>>> example:
>>>>
>>>> [clsulliv at clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>>
>>>>     GEN     ./Makefile
>>>>     HOSTLD  scripts/kconfig/mconf
>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>>> collect2: error: ld returned 1 exit status
>>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>>>> make[2]: ***
>>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504:
>>>> menuconfig] Error 2
>>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>>> make: *** [Makefile:24: __sub-make] Error 2
>>>> Command failed.
>>>> Press any key to continue...
>>>>
>>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>>> 'make menuconfig' command.
>>>>
>>>> Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
>>>> ---
>>>>    meta/classes/kernel.bbclass | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>>> index 2f6eca382e9..e4df1531c19 100644
>>>> --- a/meta/classes/kernel.bbclass
>>>> +++ b/meta/classes/kernel.bbclass
>>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>>      inherit cml1
>>>>    +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
> What's the reasoning behind appending to KCONFIG_CONFIG_COMMAND from
> kernel.bbclass rather than appending from inside cml1.bbclass (the
> only place KCONFIG_CONFIG_COMMAND is used) or simply updating the
> default value of KCONFIG_CONFIG_COMMAND?
cml1.bbclass is also used by busybox and I don't know what sort of 
effect this may have on it.

Thanks,
Cal
>
>>>> +
>>>>    EXPORT_FUNCTIONS do_compile do_install do_configure
>>>>      # kernel-base becomes kernel-${KERNEL_VERSION}
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>