[OE-core] [PATCH V3] gcc: Do not use --with-linker-hash-style if LINKER_HASH_STYLE is empty

[Andre McCurdy]

On Fri, Mar 16, 2018 at 2:41 PM, Khem Raj <raj.khem at gmail.com> wrote:
> We allow to set LINKER_HASH_STYLE to be empty so this would fail
> since --with-linker-hash-style needs an argument and cant be empty
>
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
> Changes in v3:
> - Fix typo in gcc option
>
> Changes in v2:
> - Use inline if statement instead of old syntax
>
>  meta/recipes-devtools/gcc/gcc-7.3.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-7.3.inc b/meta/recipes-devtools/gcc/gcc-7.3.inc
> index d56d2c5e06..a80926216b 100644
> --- a/meta/recipes-devtools/gcc/gcc-7.3.inc
> +++ b/meta/recipes-devtools/gcc/gcc-7.3.inc
> @@ -100,7 +100,7 @@ EXTRA_OECONF_BASE = "\
>      --disable-bootstrap \
>      --disable-libmudflap \
>      --with-system-zlib \
> -    --with-linker-hash-style=${LINKER_HASH_STYLE} \
> +    ${@'--with-linker-hash-style=${LINKER_HASH_STYLE}' if '${LINKER_HASH_STYLE}' else ''} \

What are the rules about when to use d.getVar('FOO') -vs- when to use
${FOO} in python fragments like this?

>      --enable-linker-build-id \
>      --with-ppl=no \
>      --with-cloog=no \
> --
> 2.16.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core