[OE-core] [PATCH 1/3] systemd: upgrade to 237

Khem Raj raj.khem at gmail.com
Mon Mar 19 05:21:49 UTC 2018



On 3/18/18 9:53 PM, ChenQi wrote:
> On 03/17/2018 03:27 AM, Alexander Kanavin wrote:
>> On 03/16/2018 09:30 PM, Randy MacLeod wrote:
>>>> This new version has dropped ptest support, as there's no easy
>>>> way to do this in the framework of meson.
>>>
>>> Are you talking to the meson developers to see if we/they can
>>> come up with a way to do that? Is there an issue opened:
>>>     https://github.com/mesonbuild/meson/issues
>>> I didn't find one.
>>
>> Yes - please be more specific. What are the difficulties in building 
>> and packaging tests when meson is used, as compared to autotools? If 
>> you need to patch meson build files in systemd source tree, it's 
>> totally fine to do that.
>>
>> Alex
>>
> 
> Hi Randy & Alex,
> 
> For autotools,
> 1) if the test framework of some package is a standalone set of scripts 
> or it could be easily decoupled from Makefile, adding ptest support for 
> such package is easy.
> 2) if the test framework of some package is coupled with Makefile, we 
> need to adjust or replace vars in Makefile, install make on target and 
> rely on the Makefile to run tests. In such case, adding ptest is not easy.
> 
> For meson, the test framework is coupled with meson/ninja. We need to at 
> least install ninja and meson on target as a first step. Maybe we need 
> to adjust other things in do_install_ptest. That's why I said "there's 
> no easy way to add ptest support."
> 
> Why didn't I look further into this problem? Because I view ptest 
> support as optional, not necessary.
> What I thought was: "let's upgrade the package first. If ptest support 
> is required from community, deal with that in a separate patch."

ptest is quite important as we move into future. Although here in this 
particular case, where systemd has changed the build system and we are 
doing upgrade at same time, we might consider it, however, it should be 
an important thing to fix before release.

> 
> Now that I've got feedback from you, I think I'll look further into this 
> issue and try to add ptest support via a separate patch.



> 
> Best Regards,
> Chen Qi



More information about the Openembedded-core mailing list