[OE-core] [PATCH v2] gstreamer: enable ptest support
Anuj Mittal
anuj.mittal at intel.com
Mon Mar 19 14:36:09 UTC 2018
Hi Ross,
On 03/15/2018 01:03 AM, Burton, Ross wrote:
> On 28 February 2018 at 02:51, Anuj Mittal <anuj.mittal at intel.com
> <mailto:anuj.mittal at intel.com>> wrote:
>
> +diff --git a/Makefile.am b/Makefile.am
> +index de057c4..42e90fe 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -96,6 +96,9 @@ check-torture:
> +
> + build-checks:
> + $(MAKE) -C tests/check build-checks
> ++
> ++install-ptest:
> ++ $(MAKE) -C tests/check DESTDIR=$(DESTDIR) $@
> + else
> + check-valgrind:
>
> + echo "'check' library not installed, skipping"
>
>
> I'd say not to bother patching the top-level and instead call the right
> makefile from do_install_ptest.
I have made this change in v3.
>
> ++install-ptest: $(TESTS)
> ++ @$(INSTALL) -d $(DESTDIR)
> ++ @for dir in gst libs tools pipelines elements generic; do \
> ++ if [ -x $$dir/.libs ]; then \
> ++ $(INSTALL) -d $(DESTDIR)/$$dir; \
> ++ $(INSTALL_PROGRAM) $$dir/.libs/*
> $(DESTDIR)/$$dir/; \
> ++ fi \
> ++ done
>
>
> Can this do string functions on TESTS instead of hard-coding the list of
> directories?
TESTS is a list of <dir_name>/<test_name> and wouldn't have been
appropriate to get just the directory names. I used find to get the
first level directories instead.
Thanks,
Anuj
>
> Ross
More information about the Openembedded-core
mailing list