[OE-core] [PATCH 1/2] sanity.bbclass: quote path passed to stat in get_filesystem_id()

[Burton, Ross]

A better fix would be to not use getstatusoutput() at all, but
directly hit subprocess and pass the argument as a list.

Ross

On 24 March 2018 at 04:55, Andre McCurdy <armccurdy at gmail.com> wrote:
> Although get_filesystem_id() is a private API and never gets passed
> a path containing spaces or other special characters, etc, quote the
> path anyway for consistency.
>
> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
> ---
>  meta/classes/sanity.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 6716985..e0e57ce 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -336,7 +336,7 @@ def check_path_length(filepath, pathname, limit):
>      return ""
>
>  def get_filesystem_id(path):
> -    status, result = oe.utils.getstatusoutput("stat -f -c '%s' %s" % ("%t", path))
> +    status, result = oe.utils.getstatusoutput("stat -f -c '%s' '%s'" % ("%t", path))
>      if status == 0:
>          return result
>      else:
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core