[OE-core] [PATCH v2 2/8] babeltrace: move ASNEEDED over-ride into the babeltrace recipe

[Khem Raj]

On Wed, May 9, 2018 at 2:46 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
> Move the recipe specific over-ride for ASNEEDED into the recipe to
> make it more apparent that the over-ride is being applied (and that
> it should be re-checked on version updates, etc).
>

I think this patchset is good however two things, squash all Oe-core as-needed
moves to one commit. secondly, check if they are still needed, if so then a line
or two documenting what the problem is may be as a followup
Thirdly, deleted as-needed.inc and append this option to TARGET_LDFLAGS
directly in bitbake.conf

> Also misc minor recipe cleanup (re-order variables to follow the OE
> style guide, etc).
>
> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
> ---
>  meta/conf/distro/include/as-needed.inc        |  1 -
>  meta/recipes-kernel/lttng/babeltrace_1.5.5.bb | 12 ++++++------
>  2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/meta/conf/distro/include/as-needed.inc b/meta/conf/distro/include/as-needed.inc
> index 6a8ad9d..38de3a1 100644
> --- a/meta/conf/distro/include/as-needed.inc
> +++ b/meta/conf/distro/include/as-needed.inc
> @@ -1,7 +1,6 @@
>
>  ASNEEDED = "-Wl,--as-needed"
>
> -ASNEEDED_pn-babeltrace = ""
>  ASNEEDED_pn-console-tools = ""
>  ASNEEDED_pn-distcc = ""
>  ASNEEDED_pn-openobex = ""
> diff --git a/meta/recipes-kernel/lttng/babeltrace_1.5.5.bb b/meta/recipes-kernel/lttng/babeltrace_1.5.5.bb
> index 5d7a7ef..2a2fa1e 100644
> --- a/meta/recipes-kernel/lttng/babeltrace_1.5.5.bb
> +++ b/meta/recipes-kernel/lttng/babeltrace_1.5.5.bb
> @@ -2,18 +2,18 @@ SUMMARY = "Babeltrace - Trace Format Babel Tower"
>  DESCRIPTION = "Babeltrace provides trace read and write libraries in host side, as well as a trace converter, which used to convert LTTng 2.0 traces into human-readable log."
>  HOMEPAGE = "http://www.efficios.com/babeltrace/"
>  BUGTRACKER = "https://bugs.lttng.org/projects/babeltrace"
> -
>  LICENSE = "MIT & GPLv2"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=76ba15dd76a248e1dd526bca0e2125fa"
>
>  DEPENDS = "glib-2.0 util-linux popt bison-native flex-native"
>
> -inherit autotools pkgconfig
> +SRC_URI = "git://git.linuxfoundation.org/diamon/babeltrace.git;branch=stable-1.5"
> +SRCREV = "d68a4daf85c73ab7d7070de0c98d0c170af4758e"
> +
> +S = "${WORKDIR}/git"
>
> -SRC_URI = "git://git.linuxfoundation.org/diamon/babeltrace.git;branch=stable-1.5 \
> -"
> +inherit autotools pkgconfig
>
>  EXTRA_OECONF = "--disable-debug-info"
>
> -S = "${WORKDIR}/git"
> -SRCREV = "d68a4daf85c73ab7d7070de0c98d0c170af4758e"
> +ASNEEDED = ""
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core