[OE-core] [PATCH 2/2] rpm: Assume a max limit of 1024 open files
Alexander Kanavin
alexander.kanavin at linux.intel.com
Fri May 11 05:43:30 UTC 2018
On 05/11/2018 01:20 AM, Peter Kjellerstedt wrote:
> If sysconf(_SC_OPEN_MAX) is much greater than the usual 1024 (for
> example inside a Docker container), the performance drops sharply.
Please do not drop the link to the upstream bug when replacing one patch
with another. You can also simply amend my patch and add your SOB.
Also, why assume specifically 1024? We either need to close all the open
files, or none, and your patch creates a situation where only some of
the files may be closed. I'd say we should drop those two code snippets
altogether instead of hardcoding 1024 into them.
Oh, and: please do comment in the upstream bug (e.g. with your
benchmarks from the cover letter), otherwise upstream may do nothing
because they're not using Docker.
Alex
More information about the Openembedded-core
mailing list