[OE-core] [PATCH 4/4] sstate: avoid indirect bison/flex-native dependencies (via SSTATE_EXCLUDEDEPS_SYSROOT)

[André Draszik]

On Tue, 2018-05-22 at 13:33 +0100, Richard Purdie wrote:
> On Tue, 2018-05-22 at 13:25 +0100, André Draszik wrote:
> > From: André Draszik <andre.draszik at jci.com>
> > 
> > Avoid adding flex-native or bison-native to the sysroot without a
> > specific
> > dependency in the recipe. This means indirect dependencies
> > (e.g. X -> Y -> binutils-cross -> flex-native) no longer meet the
> > dependency incidentally. This improves determinism and avoids build
> > failures when people switch to external toolchains.
> > 
> > Based on an idea by Richard Purdie:
> >     http://lists.openembedded.org/pipermail/openembedded-core/2018-Ja
> > nuary/146324.html
> > 
> > Signed-off-by: André Draszik <andre.draszik at jci.com>
> > ---
> >  meta/conf/layer.conf | 6 ++++++
> >  1 file changed, 6 insertions(+)
> 
> The trouble was that the patch above of mine doesn't actually work and
> breaks things from what I remember, some issue showed up in testing on
> our autobuilder. I don't remember exactly what it breaks unfortunately
> :(.

Well, I did test this series with the images I build, and nothing broke,
except for one missing dependency in meta-oe, for which I've sent a patch
already.

I think your patch placed the skipping in the wrong place? Maybe it was
intentional, but I have it in a different place, and I don't return (True)
on a match, but continue iterating over the remaining items.

In any case, if there are other breakages caused by this, the autobuilder
would at least have a log message, so I can fix the patch hopefully... :-)

Cheers,
Andre'