[OE-core] [morty][PATCH 1/3] package.bbclass: use single quotes for path passed to file in isELF()

[akuster808]

On 05/25/2018 12:16 PM, Andre McCurdy wrote:
> Apparently there are recipes in the wild which generate files with
> filenames containing '$' characters - which cause errors during
> packaging.
>
> Instead of adding another special case to escape '$' characters when
> constructing the command passed to oe.utils.getstatusoutput(), switch
> to using single quotes to quote the path - and therefore make isELF()
> consistent with the way filenames and paths are quoted by every other
> caller of oe.utils.getstatusoutput() in oe-core.
this series in stable/pyro-mnut

- armin
> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> (cherry picked from commit 7877761534b0c2492da6289e9f2269d41b6ed464)
> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
> ---
>  meta/classes/package.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index a6f0a7a..531ca4a 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -892,7 +892,7 @@ python split_and_strip_files () {
>      # 16 - kernel module
>      def isELF(path):
>          type = 0
> -        ret, result = oe.utils.getstatusoutput("file \"%s\"" % path.replace("\"", "\\\""))
> +        ret, result = oe.utils.getstatusoutput("file '%s'" % path)
>  
>          if ret:
>              msg = "split_and_strip_files: 'file %s' failed" % path