[OE-core] ✗ patchtest: failure for systemd: backport patches to fix 3 CVEs (rev2)

ChenQi Qi.Chen at windriver.com
Fri Nov 2 06:37:18 UTC 2018


Hi All,

I finally found out the problem. I think the cve tag checking logic in 
patchtest-oe has some problem.

The current logic errors out if and only if the patch has a line which 
begins with 'CVE-YYYY-XXXX' and contains nothing else. It does not error 
out if the patch contains no CVE information, nor will it error out if 
the patch contains line like ' CVE-YYYY-XXXX' (spaces followed by cve 
id). What's worse, if the backported patch itself contains a line 
'CVE-YYYY-XXXX', this cve tag checking code errors out, and this is the 
error I got in this patch.

I've sent out a patch to yocto to fix this issue.
Title is: [yocto] [patchtest-oe][PATCH] test_patch_cve.py: fix cve tag 
checking logic

Do you think I need to tweak the patches according to the current cve 
tag checking rule and send out V3?

Best Regards,
Chen Qi

On 11/02/2018 01:03 PM, Patchwork wrote:
> == Series Details ==
>
> Series: systemd: backport patches to fix 3 CVEs (rev2)
> Revision: 2
> URL   : https://patchwork.openembedded.org/series/14759/
> State : failure
>
> == Summary ==
>
>
> Thank you for submitting this patch series to OpenEmbedded Core. This is
> an automated response. Several tests have been executed on the proposed
> series by patchtest resulting in the following failures:
>
>
>
> * Patch            [1/3] systemd: fix CVE-2018-15686
>   Issue             Missing or incorrectly formatted CVE tag in included patch file [test_cve_tag_format]
>    Suggested fix    Correct or include the CVE tag on cve patch with format: "CVE: CVE-YYYY-XXXX"
>
>
>
> If you believe any of these test results are incorrect, please reply to the
> mailing list (openembedded-core at lists.openembedded.org) raising your concerns.
> Otherwise we would appreciate you correcting the issues and submitting a new
> version of the patchset if applicable. Please ensure you add/increment the
> version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> [PATCH v3] -> ...).
>
> ---
> Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
>
>




More information about the Openembedded-core mailing list