[OE-core] [PATCHv2] glibc: make ld-2.28.so reproducible on arm

[akuster808]

Martin,


On 11/6/18 2:04 AM, Martin Hundebøll wrote:
> Play the whack-a-mole game and add the .file directive to another
> assembly file that otherwise shows itself in ld-2.28.so debug file,
> which in turns alters the build-id of ld-2.28.so on target.
>
> Signed-off-by: Martin Hundebøll <martin at geanix.com>
> ---
>
> Changes since v1:
>
>  - Added signed-of-by tag
>
>  .../0034-inject-file-assembly-directives.patch      | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/meta/recipes-core/glibc/glibc/0034-inject-file-assembly-directives.patch b/meta/recipes-core/glibc/glibc/0034-inject-file-assembly-directives.patch
> index 3f9f8cf189..55eba2d43e 100644
> --- a/meta/recipes-core/glibc/glibc/0034-inject-file-assembly-directives.patch
> +++ b/meta/recipes-core/glibc/glibc/0034-inject-file-assembly-directives.patch
> @@ -257,3 +257,16 @@ index 244d87fb6d..14d3e2ce14 100644
>   /* Initial entry point code for the dynamic linker.
>      The C function `_dl_start' is the real entry point;
>      its return value is the user program's entry point.	*/

Please add Upsteam-Status: and Signed-off-by: in the patch itself.

You may want to review
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

This seems like a backport candidate for Thud too?

regards,

Armin

> +diff --git a/sysdeps/unix/sysv/linux/arm/libc-do-syscall.S b/sysdeps/unix/sysv/linux/arm/libc-do-syscall.S
> +index d26ad1f8d3..a0de10bf81 100644
> +--- a/sysdeps/unix/sysv/linux/arm/libc-do-syscall.S
> ++++ b/sysdeps/unix/sysv/linux/arm/libc-do-syscall.S
> +@@ -27,6 +27,8 @@
> +    ARM unwind tables for register to register moves, the actual opcodes
> +    are not defined.  */
> + 
> ++      .file "libc-do-syscall.S"
> ++
> + #if defined(__thumb__)
> + 	.thumb
> + 	.syntax unified