[OE-core] [PATCH] glib-2.0: add missing locale dependencies to PN-ptest

[Burton, Ross]

Sounds about right.  Not sure what would count as a solution here?

Ross
On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno at vaisala.com> wrote:
>
> On 10/09/2018 02:00 PM, Ross Burton wrote:
> > The test suite skips several tests if the required locales are not found, so add
> > them as dependencies of glib-2.0-ptest.
> >
> > Signed-off-by: Ross Burton <ross.burton at intel.com>
> > ---
> >   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> > index ad4f2aebd71..f78aa9bfe6d 100644
> > --- a/meta/recipes-core/glib-2.0/glib.inc
> > +++ b/meta/recipes-core/glib-2.0/glib.inc
> > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
> >               glibc-gconv-iso8859-15 \
> >               glibc-charmap-invariant \
> >               glibc-localedata-translit-cjk-variants \
> > +            locale-base-tr-tr \
> > +            locale-base-lt-lt \
> > +            locale-base-ja-jp.euc-jp \
> > +            locale-base-fa-ir \
> > +            locale-base-ru-ru \
> > +            locale-base-de-de \
> > +            locale-base-pl-pl \
> > +            locale-base-hr-hr \
> > +            locale-base-el-gr \
> > +            locale-base-fr-fr \
> > +            locale-base-fr-fr \
> > +            locale-base-es-es \
> > +            locale-base-en-gb \
> >              "
> >
> >   INSANE_SKIP_${PN}-ptest += "libdir"
> >
>
> Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:
>
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]
>
> If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.
>
> -Niko