[OE-core] [PATCH] avahi: add ptest

[Stefan Strogin]

Hi Ross,

On 09/11/2018 15:29, Burton, Ross wrote:
> On Thu, 8 Nov 2018 at 09:44, Stefan Strogin via Openembedded-core
> <openembedded-core at lists.openembedded.org> wrote:
>> +do_install_ptest () {
>> +    install -d ${D}${PTEST_PATH}/test/.libs
>> +    for t in dns-spin-test dns-test hashmap-test
>> +    do
>> +        install -m 0755 ${B}/avahi-core/$t ${D}${PTEST_PATH}/test/
>> +        sed -e 's/^relink_command=\"\(.*\)\"/relink_command=\"\"/' -i ${D}${PTEST_PATH}/test/$t
>> +        install -m 0755 ${B}/avahi-core/.libs/$t ${D}${PTEST_PATH}/test/.libs/lt-$t
>> +    done
>> +}
> 
> Whilst I really do want to see more test suites, is this really a
> useful test suite?  hashmap-test is a validation that the hash
> implementation works, dns-test is low-level parsing, and dns-spin-test
> is basically a way to verify an Avahi bug doesn't regress.  This isn't
> exactly a full-featured test suite that creates services, ensures
> they're browsable, enumerate stuff, etc.

Thanks for the good comment. In our distro we also want to cover with tests
as many packages as possible. There are more tests in avahi source code like
avahi-test, conformance-test, querier-test, update-test...

Unfortunately the test suite is not documented at all (at least I couldn't
find any documentation on them), and I'm not very familiar with Avahi API
and the source code.
Some of the tests in case of success seem to run in an infinite loop, and exit
only in case of error. So I couldn't include them into the recipe. Maybe the
tests need to be patched [upstream].
I began to investigate it but unfortunately didn't have time, and now I have
some more urgent tasks. So I added only those tests in which I'm sure, perhaps
it's too few.
I hope to add more tests some day, or somebody else will be able to do it.

--
Stefan