[OE-core] [PATCH] scripts: Use fixed temporary file instead of pipe for here-doc

[richard.purdie at linuxfoundation.org]

On Wed, 2018-11-21 at 18:21 +0800, He Zhe wrote:
> 
> On 2018/11/21 18:07, Richard Purdie wrote:
> > On Wed, 2018-11-21 at 17:39 +0800, zhe.he at windriver.com wrote:
> > > From: He Zhe <zhe.he at windriver.com>
> > > 
> > > A workaround for possible "*** Compiler lacks asm-goto support..
> > > Stop."
> > > linux-libc-headers is built by gcc on build machine, which could
> > > not
> > > contain the
> > > fix.
> > > 
> > > Signed-off-by: He Zhe <zhe.he at windriver.com>
> > > ---
> > >  ...-fixed-temporary-file-instead-of-pipe-for.patch | 60
> > > ++++++++++++++++++++++
> > >  .../linux-libc-headers/linux-libc-headers_4.18.bb  |  4 ++
> > >  2 files changed, 64 insertions(+)
> > >  create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-
> > > libc-headers/0001-scripts-Use-fixed-temporary-file-instead-of-
> > > pipe-
> > > for.patch
> > 
> > How old is an "old gcc"?
> 
> I put the full explanation in the commit log of the patch inside.

No, you did not. I went and looked at the link (which I had to un-line
wrap) to understand this and the problem is in binutils in the
assembler (as), *not* gcc. Its also not just some "old gcc" but any
current released version of binutils which is quite different.

Please improve the commit message to reference binutils, not gcc,
mention the current version of bintuils (2.31) and that it and all
previous versions have the bug.

Also please set the Upstream-Status correctly.

> The fix below for the bug has not been released from upstream. Since
> there has
> not been gcc-cross when building linux-libc-headers, we have to use
> build
> machine gcc which could not contain the fix for the moment. To work
> around the
> error, we create a fixed temporary file to contain the program being
> tested.
> 
> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=
> 2a50366ded329bfb39d387253450c9d5302c3503
> 
> > 
> > If this isn't going upstream, I'm not sure we want to take and
> > carry
> > this either. Unless this is a gcc people would commonly run into
> > I'm
> > tempted not to take this.
> 
> This is a gcc issue, but the fix would not quickly goto versions
> being used
> by users. So this patch is used as a workaround to prevent the
> failure.
> 
> To be specific, we encountered this in docker where the /tmp could be
> rarely used that very low number inode may be allocated and triggers
> the error.

That should also be mentioned in the commit message as that does put it
in a different light.

> > 
> > Also, your patch subject is wrong as this does not change our
> > scripts
> > directory.
> 
> If this is OK, I'll send v2 to change the subject.

Along with the other changes please.

Thanks,

Richard