[OE-core] [PATCH] mesa: Disable asm on musl

Paul Eggleton paul.eggleton at linux.intel.com
Tue Oct 2 21:19:00 UTC 2018


Can we have bit more detail in the commit message about what the issues are? 
We're not supposed to rely solely on a bug report reference to do that; also 
if it's considered a workaround and we're working with upstream to fix it, the 
commit message should state that as well.

Thanks
Paul

On Wednesday, 3 October 2018 8:37:10 AM NZDT Khem Raj wrote:
> I think it is. The way th calls are set for performance reasons seems to be
> causing this
> Ideally we should ensure to use right dialect for  tls calls I think musl
> is exposing a bug in Mesa
> Which we covered by disabling tls in Glx once we disable that then this
> problem pops up so we disable ASM
> 
> So this is a workaround until then
> 
> On Tue, Oct 2, 2018 at 12:28 PM Burton, Ross <ross.burton at intel.com> wrote:
> 
> > Isn't this a bit overkill?  Is the assembler actually broken?
> >
> > Ross
> > On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem at gmail.com> wrote:
> > >
> > > some unknown part of mesa's x86 assembly
> > > code is broken by readonly text segments
> > >
> > > [ YOCTO #12918 ]
> > >
> > > Signed-off-by: Khem Raj <raj.khem at gmail.com>
> > > ---
> > >  meta/recipes-graphics/mesa/mesa.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-graphics/mesa/mesa.inc
> > b/meta/recipes-graphics/mesa/mesa.inc
> > > index 8d0e2cb67c..e6f3712706 100644
> > > --- a/meta/recipes-graphics/mesa/mesa.inc
> > > +++ b/meta/recipes-graphics/mesa/mesa.inc
> > > @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] =
> > "--enable-${OSMESA},--disable-${OSMESA}"
> > >  PACKAGECONFIG[unwind] =
> > "--enable-libunwind,--disable-libunwind,libunwind"
> > >
> > >  EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
> > > -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
> > > +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
> > >  # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
> > >  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
> > >
> > > --
> > > 2.19.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core at lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
> 


-- 

Paul Eggleton
Intel Open Source Technology Centre





More information about the Openembedded-core mailing list