[OE-core] [PATCH] lib/oe/utils: add eol to format_pkg_list()

[Richard Purdie]

On Mon, 2018-10-01 at 18:47 +0300, grygorii tertychnyi via
Openembedded-core wrote:
> Append '\n' to the formatted string before return. If you write it
> to the (manifest) file, it will ensure file ends with a newline.
> 
> Many GNU utilities have problems processing the last line of a file
> if it is not '\n' terminated. E.g. if the last line is not terminated
> by a newline character, then "read" will read it but return false,
> leaving the broken partial line in the read variable(s).
> It can also break or adversely affect some text processing tools,
> that operate on the file.
> 
> Signed-off-by: grygorii tertychnyi <gtertych at cisco.com>
> ---
>  meta/lib/oe/utils.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

If you enable buildhistory (INHERIT += 'buildhistory' in local.conf)
and then "bitbake buildtools-tarball", you'll see:

| DEBUG: Python function buildhistory_list_installed_sdk_target finished
| NOTE: Executing buildhistory_get_sdk_installed_target ...
| DEBUG: Executing shell function buildhistory_get_sdk_installed_target
| basename: missing operand
| Try 'basename --help' for more information.
| WARNING: /home/pokybuild/yocto-worker/nightly-arm/build/build/tmp/work/x86_64-nativesdk-pokysdk-linux/buildtools-tarball/1.0-r0/temp/run.buildhistory_get_sdk_installed_target.13414:1 exit 123 from 'xargs -n1 basename > $1/installed-packages.txt'
| DEBUG: Python function do_populate_sdk finished
| ERROR: Function failed: buildhistory_get_sdk_installed_target (log file is located at /home/pokybuild/yocto-worker/nightly-arm/build/build/tmp/work/x86_64-nativesdk-pokysdk-linux/buildtools-tarball/1.0-r0/temp/log.do_populate_sdk.13414)

which is buildhistory choking on the blank line.

Cheers,

Richard