[OE-core] [PATCH v2] lib/oe/utils: add eol to format_pkg_list()

Richard Purdie richard.purdie at linuxfoundation.org
Thu Oct 4 17:03:56 UTC 2018


On Thu, 2018-10-04 at 08:29 +0300, grygorii tertychnyi via
Openembedded-core wrote:
> Append '\n' to the non-empty formatted string before return. If you
> write it to the (manifest) file, it will ensure file ends with a
> newline.
> 
> Many GNU utilities have problems processing the last line of a file
> if it is not '\n' terminated. E.g. if the last line is not terminated
> by a newline character, then "read" will read it but return false,
> leaving the broken partial line in the read variable(s).
> It can also break or adversely affect some text processing tools,
> that operate on the file.
> 
> Signed-off-by: grygorii tertychnyi <gtertych at cisco.com>
> ---
> 
> Changes in v2:
>  o make sure we don't append '\n' to the empty string

This still breaks things which doesn't give me much confidence in this
change for 2.6 :(.

https://autobuilder.yoctoproject.org/typhoon/#/builders/28/builds/90/st
eps/7/logs/step2d
https://autobuilder.yoctoproject.org/typhoon/#/builders/24/builds/87/st
eps/7/logs/step4b

and more...

Cheers,

Richard



More information about the Openembedded-core mailing list