[OE-core] [PATCH] glibc: Do not use thumb1 ISA on armv6

[Khem Raj]

On Fri, Oct 12, 2018 at 1:56 PM Andre McCurdy <armccurdy at gmail.com> wrote:
>
> On Fri, Oct 12, 2018 at 1:28 PM, Khem Raj <raj.khem at gmail.com> wrote:
> > This does not work and is unsupported so lets compile glibc in ARM mode
> > always on armv6 SOCs
>
> Note the comments in glibc-collateral.inc:
>
>   # This needs to match with glibc.inc, otherwise glibc-scripts and glibc-locale
>   # will fail to find main glibc, for details see
>   # http://lists.openembedded.org/pipermail/openembedded-core/2015-January/100679.html
>   ARM_INSTRUCTION_SET_armv4 = "arm"
>   ARM_INSTRUCTION_SET_armv5 = "arm"
>
> Either the two recipes need to be kept in sync or the comment no longer applies?

I think we can delete comment in a followup

>
> > Fixes [YOCTO #12929]
> >
> > Signed-off-by: Khem Raj <raj.khem at gmail.com>
> > ---
> >  meta/recipes-core/glibc/glibc.inc | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-core/glibc/glibc.inc b/meta/recipes-core/glibc/glibc.inc
> > index ddf0c6b80e..99c92ce46e 100644
> > --- a/meta/recipes-core/glibc/glibc.inc
> > +++ b/meta/recipes-core/glibc/glibc.inc
> > @@ -56,6 +56,7 @@ INHIBIT_DEFAULT_DEPS = "1"
> >  # http://lists.openembedded.org/pipermail/openembedded-core/2015-January/100679.html
> >  ARM_INSTRUCTION_SET_armv4 = "arm"
> >  ARM_INSTRUCTION_SET_armv5 = "arm"
> > +ARM_INSTRUCTION_SET_armv6 = "arm"
> >
> >  # glibc uses PARALLELMFLAGS variable to pass parallel build info so transfer
> >  # PARALLEL_MAKE into PARALLELMFLAGS and empty out PARALLEL_MAKE
> > --
> > 2.19.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core