[OE-core] [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Martin Jansa]

Hmm, you're right 5397ae5 would be better with just DISTRO_FEATURES
replaced with BLUEZ variable in

RDEPENDS_${PN} = " \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', '${BLUEZ5_INSTALL}',
"", d)} \
     ${@bb.utils.contains('DISTRO_FEATURES', 'bluez4', '${BLUEZ4_INSTALL}',
"", d)} \
"

Then it would work fine for both use cases and empty BLUEZ as well.

On Wed, Oct 17, 2018 at 5:47 PM Yann Dirson <yann.dirson at blade-group.com>
wrote:

> Well, inline python was what was originally used before 5397ae5.
>
> Le mer. 17 oct. 2018 à 17:46, Martin Jansa <martin.jansa at gmail.com> a
> écrit :
>
>> well, I realized that this won't work with the BLUEZ intentionally set to
>> empty value and setting BLUEZ to no-bluetooth globally also probably won't
>> work for cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe
>> inline python appending only either bluez4 or bluez5 alternative here?
>>
>> On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <yann.dirson at blade-group.com>
>> wrote:
>>
>>> Yeah, that looks like a better idea.
>>>
>>> Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa at gmail.com> a
>>> écrit :
>>>
>>>> What about using some less confusing default BLUEZ value? RDEPENDS_
>>>> looks wrong.
>>>>
>>>> BLUEZ ??= "no-bluetooth"
>>>> RDEPENDS_no-bluetooth = ""
>>>>
>>>> Might be a bit more clear.
>>>>
>>>> On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson at blade-group.com> wrote:
>>>>
>>>>> From: Yann Dirson <yann at blade-group.com>
>>>>>
>>>>> Otherwise the build fails with:
>>>>>
>>>>>   NOTE: Runtime target '${RDEPENDS_}' is unbuildable, removing...
>>>>>   Missing or unbuildable dependency chain was: ['${RDEPENDS_}']
>>>>>
>>>>> This restores some truth in the "Otherwise install nothing" comment in
>>>>> the recipe.
>>>>>
>>>>> Signed-off-by: Yann Dirson <yann at blade-group.com>
>>>>> ---
>>>>>  .../packagegroups/packagegroup-tools-bluetooth.bb               | 2
>>>>> ++
>>>>>  1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> b/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> index 0ede5e57b..e81516fef 100644
>>>>> --- a/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> +++ b/meta-oe/recipes-connectivity/packagegroups/
>>>>> packagegroup-tools-bluetooth.bb
>>>>> @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
>>>>>          '', d)} \
>>>>>  "
>>>>>
>>>>> +RDEPENDS_ = ""
>>>>> +
>>>>>  # Install bluez4 tools or bluez5 tools depending on what is specified
>>>>> in the distro.
>>>>>  # Otherwise install nothing.
>>>>>  RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
>>>>> --
>>>>> 2.19.1
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core at lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>>
>>>>
>>>
>>> --
>>> Yann Dirson <yann at blade-group.com>
>>> Blade -- 38 rue du Sentier, 75002 Paris
>>>
>>
>
> --
> Yann Dirson <yann at blade-group.com>
> Blade -- 38 rue du Sentier, 75002 Paris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20181017/7d51f6a7/attachment-0002.html>