[OE-core] [PATCH] packagegroup-tools-bluetooth: work as advertized on distro without bluez* support

[Yann Dirson]

Sent v3 to -devel - that does not supercede the original series on patwork,
though.

Le mer. 17 oct. 2018 à 20:52, Martin Jansa <martin.jansa at gmail.com> a
écrit :

> On Wed, Oct 17, 2018 at 10:58:49AM -0500, Mark Hatle wrote:
> > On 10/17/18 10:46 AM, Martin Jansa wrote:
> > > well, I realized that this won't work with the BLUEZ intentionally set
> to empty
> > > value and setting BLUEZ to no-bluetooth globally also probably won't
> work for
> > > cases where it might be used in e.g. RDEPENDS_${PN} :/. Maybe inline
> python
> > > appending only either bluez4 or bluez5 alternative here?
> >
> > I'm slightly confused.  In the suggestion you made below, ??= within the
> > specific package, why would 'no-bluetooth' cause a problem.  For all
> other
> > recipes it will remain blank as expected.
>
> Because if you set it to empty, then ??= won't be used and we'll be back
> to RDEPENDS_.
>
> And if you set BLUEZ to no-bluetooth e.g. in your DISTRO config than it
> will break other recipes, e.g.:
>
> meta/recipes-connectivity/ofono/ofono.inc:PACKAGECONFIG[bluez] =
> "--enable-bluetooth, --disable-bluetooth, ${BLUEZ}"
> meta/recipes-core/packagegroups/packagegroup-base.bb:    ${BLUEZ} \
> meta/recipes-devtools/python/python3.inc:PACKAGECONFIG[bluetooth] =
> ",ac_cv_header_bluetooth_bluetooth_h=no
> ac_cv_header_bluetooth_h=no,${BLUEZ}"
> meta/recipes-devtools/qemu/qemu.inc:PACKAGECONFIG[bluez] =
> "--enable-bluez,--disable-bluez,${BLUEZ}"
> meta/recipes-devtools/strace/strace_4.24.bb:PACKAGECONFIG[bluez] =
> "ac_cv_header_bluetooth_bluetooth_h=yes,ac_cv_header_bluetooth_bluetooth_h=no,${BLUEZ}"
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.2.bb:PACKAGECONFIG[bluez]
>          = "--enable-bluez,--disable-bluez,${BLUEZ}"
>
> > --Mark
> >
> > > On Wed, Oct 17, 2018 at 5:43 PM Yann Dirson <
> yann.dirson at blade-group.com
> > > <mailto:yann.dirson at blade-group.com>> wrote:
> > >
> > >     Yeah, that looks like a better idea.
> > >
> > >     Le mer. 17 oct. 2018 à 17:27, Martin Jansa <martin.jansa at gmail.com
> > >     <mailto:martin.jansa at gmail.com>> a écrit :
> > >
> > >         What about using some less confusing default BLUEZ value?
> RDEPENDS_
> > >         looks wrong.
> > >
> > >         BLUEZ ??= "no-bluetooth"
> > >         RDEPENDS_no-bluetooth = ""
> > >
> > >         Might be a bit more clear.
> > >
> > >         On Wed, Oct 17, 2018 at 5:08 PM <yann.dirson at blade-group.com
> > >         <mailto:yann.dirson at blade-group.com>> wrote:
> > >
> > >             From: Yann Dirson <yann at blade-group.com <mailto:
> yann at blade-group.com>>
> > >
> > >             Otherwise the build fails with:
> > >
> > >               NOTE: Runtime target '${RDEPENDS_}' is unbuildable,
> removing...
> > >               Missing or unbuildable dependency chain was:
> ['${RDEPENDS_}']
> > >
> > >             This restores some truth in the "Otherwise install
> nothing" comment
> > >             in the recipe.
> > >
> > >             Signed-off-by: Yann Dirson <yann at blade-group.com
> > >             <mailto:yann at blade-group.com>>
> > >             ---
> > >              .../packagegroups/packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>               |
> 2 ++
> > >              1 file changed, 2 insertions(+)
> > >
> > >             diff --git
> > >             a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             index 0ede5e57b..e81516fef 100644
> > >             ---
> > >             a/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             +++
> > >             b/meta-oe/recipes-connectivity/packagegroups/
> packagegroup-tools-bluetooth.bb
> > >             <http://packagegroup-tools-bluetooth.bb>
> > >             @@ -32,6 +32,8 @@ RDEPENDS_bluez5 = " \
> > >                      '', d)} \
> > >              "
> > >
> > >             +RDEPENDS_ = ""
> > >             +
> > >              # Install bluez4 tools or bluez5 tools depending on what
> is
> > >             specified in the distro.
> > >              # Otherwise install nothing.
> > >              RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
> > >             --
> > >             2.19.1
> > >
> > >             --
> > >             _______________________________________________
> > >             Openembedded-core mailing list
> > >             Openembedded-core at lists.openembedded.org
> > >             <mailto:Openembedded-core at lists.openembedded.org>
> > >
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> > >
> > >
> > >
> > >     --
> > >     Yann Dirson <yann at blade-group.com <mailto:yann at blade-group.com>>
> > >     Blade -- 38 rue du Sentier, 75002 Paris
> > >
> > >
> > >
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>


-- 
Yann Dirson <yann at blade-group.com>
Blade -- 38 rue du Sentier, 75002 Paris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20181017/e323baed/attachment-0002.html>