[OE-core] [PATCH v2][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND

[Bruce Ashfield]

On 10/30/18 1:02 PM, Andre McCurdy wrote:
> On Mon, Oct 29, 2018 at 8:39 PM Bruce Ashfield
> <bruce.ashfield at windriver.com> wrote:
>>
>> As was warned by commit 312ee68752fa [kconfig: announce removal of
>> oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.
>>
>> So we switch our default mode to olddefconfig.
>>
>> commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',
>> and keep the old name as an alias] introduced olddefconfig in the 3.10
>> kernel, we shuffle oldnoconfig to the fallback target.
>>
>> The fallback mode allows kernels between 3.10 and the currently listed
>> oldest kernel of 3.2 to continue to configure.
>>
>> Signed-off-by: Bruce Ashfield <bruce.ashfield at windriver.com>
>> ---
>>
>> v2: Tweaked to add a fallback mode as suggested by Andre McCurdy
>>
>> Not for the release, just wanted to get this in the queue for
>> when master reopens so we'll be ready for 4.20+ kernel versions
>>
>> Bruce
>>
>>
>>   meta/classes/kernel.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index e04d2fe00434..8fe207165ae8 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -492,7 +492,7 @@ sysroot_stage_all () {
>>          :
>>   }
>>
>> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} oldnoconfig"
>> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig"
> 
> There's no "yes" needed with oldnoconfig. The new fallback should just
> be the existing default command.

*shrug*

I'll leave this as is, since it works as tested. Feel free to
send followups.

Bruce

> 
>>   python check_oldest_kernel() {
>>       oldest_kernel = d.getVar('OLDEST_KERNEL')
>> --
>> 2.5.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core