[OE-core] [PATCH 5/7] wic:direct:remove same entry when updating fstab

Tom Rini trini at konsulko.com
Mon Sep 3 02:51:35 UTC 2018


On Mon, Sep 03, 2018 at 10:00:45AM +0800, Lu.Jiang wrote:
> 在 2018年08月31日 21:54, Tom Rini 写道:
> >On Fri, Aug 31, 2018 at 10:15:08AM +0800, Jiang Lu wrote:
> >
> >>Remove same mountpoint entry when updating fstab.
> >>
> >>Signed-off-by: Jiang Lu <lu.jiang at windriver.com>
> >>---
> >>  meta/recipes-support/wic/files/wic/plugins/imager/direct.py | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >>diff --git a/meta/recipes-support/wic/files/wic/plugins/imager/direct.py b/meta/recipes-support/wic/files/wic/plugins/imager/direct.py
> >>index f648db4..d3ebc9c 100644
> >>--- a/meta/recipes-support/wic/files/wic/plugins/imager/direct.py
> >>+++ b/meta/recipes-support/wic/files/wic/plugins/imager/direct.py
> >>@@ -163,6 +163,9 @@ class DirectPlugin(ImagerPlugin):
> >>              opts = part.fsopts if part.fsopts else "defaults"
> >>              line = "\t".join([device_name, part.mountpoint, part.fstype,
> >>                                opts, "0", "0"]) + "\n"
> >>+            for tmpline in fstab_lines:
> >>+                if part.mountpoint in tmpline:
> >>+                    fstab_lines.remove(tmpline)
> >>              fstab_lines.append(line)
> >>              updated = True
> >Can you explain how this happens?
> >
> The patch intend to fix a issue when running wic on target.
> 
> On target, I'd like wic create a new image based on current running rootfs.
> Then the fstab from running system need remove duplicated entry.

Please put something about this in the commit message, thanks.

-- 
Tom



More information about the Openembedded-core mailing list