[OE-core] [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia]

On 2018年09月03日 17:54, Alexander Kanavin wrote:
> 2018-09-03 11:35 GMT+02:00 Hongxu Jia <hongxu.jia at windriver.com>:
>> They can't be built without opengl in DISTRO_FEATURES.
>> [snip]
>> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
>> fatal error: GL/gl.h: No such file or directory
>> [snip]
> Apologies, but NAK.
>
> Webkit recipe already has the necessary configuration to handle this:
>
> PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
> 'x11', 'wayland' ,d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'opengl',
> 'webgl opengl', '' ,d)} \
>
> PACKAGECONFIG[webgl] = "-DENABLE_WEBGL=ON,-DENABLE_WEBGL=OFF,virtual/libgl"
> PACKAGECONFIG[opengl] = "-DENABLE_OPENGL=ON,-DENABLE_OPENGL=OFF,virtual/libgl"
>
>
> If disabling opengl does not work, then you should look closer into
> why, instead of just requiring opengl to be present always.
I am afraid whether opengl or not, it always requires virtual/libql
just like Ubuntu/Fedora does.

[Fedora webkitgtk.spec]
BuildRequires:  mesa-libGL-devel
[Fedora webkitgtk.spec]

[Ubuntu debian/control]
Build-Depends: libgl1-mesa-dev [!armel !armhf !arm64]
[Ubuntu debian/control]

I tried to move `virtual/libgl' from PACKAGECONFIG to DEPENDS,
but unfortunately, the provider of `virtual/libgl' -- mesa/mesa-ql,
they require `opengl 'or `vulkan' in distro features check.

//Hongxu

> Alex