[OE-core] [PATCH] terminal.bbclass: use var-SHELL as the shebang of wrapper script

[Hongxu Jia]

On 2018年09月05日 03:14, Andre McCurdy wrote:
> Maybe I'm missing something, but what's the advantage of using SHELL
> to run this little wrapper script rather than hardcoding /bin/sh ?
>
> Task shell scripts created by bitbake use hardcoded /bin/sh (see
> bitbake/lib/bb/build.py -> shell_trap_code())

Keep align with the devshell as the comments mentioned above

...

The devshell.bbclass set var-SHELL to var-DEVSHELL, and terminal.bbclass
initial var-SHELL with `bash'. Keep sync with it, use var-SHELL rather
than hardcoded `/bin/sh' as the shebang of wrapper script.

On Ubuntu host, default shell is dash (/bin/sh -> dash), even though
we assign var-SHELL with `/bin/bash', the wrapper script is still
dashism.

...


//Hongxu