[OE-core] [PATCH] os-release: fix to install in the expected location

[Andre McCurdy]

On Wed, Sep 5, 2018 at 1:47 AM,  <richard.purdie at linuxfoundation.org> wrote:
> On Tue, 2018-09-04 at 19:04 -0700, Andre McCurdy wrote:
>> On Tue, Sep 4, 2018 at 3:36 PM, Richard Purdie
>> <richard.purdie at linuxfoundation.org> wrote:
>> > On Tue, 2018-09-04 at 13:19 -0700, Andre McCurdy wrote:
>> > > On Tue, Sep 4, 2018 at 8:50 AM, Ross Burton <ross.burton at intel.co
>> > > m>
>> > > wrote:
>> > > This probably needs an "rm -f ${D}${sysconfdir}/os-release" too
>> > > to
>> > > prevent problems if install is run twice as lnr doesn't handle
>> > > the
>> > > case where the target already exists.
>> >
>> > Doesn't do_install clean out ${D} each time it reruns though?
>>
>> Yes, it does. Sometimes it's useful to rerun the run.do_install
>> script
>> manually though.
>
> We don't support that, I think its reasonable to assume that ${D} is
> empty at the start of do_install. To do otherwise would mean changing a
> lot of do_install functions for very little gain IMO.

Most callers of lnr already explicitly remove the target first.
Ensuring new calls to lnr do the same as they are added isn't a lot of
work.