[OE-core] [PATCH] wic: squashfs does support partition uuid

[Emmanuel Roullit]

Got it.
I will tweak it and resubmit a PATCHv2 once I got it right.

On Thu, Sep 6, 2018 at 12:07 AM Tom Rini <trini at konsulko.com> wrote:

> On Wed, Sep 05, 2018 at 09:53:25PM +0200, Emmanuel Roullit wrote:
>
> > wic allows the user to create disk image and reference each created
> > partitions via its partition UUID.
> >
> > squashfs does not support filesystem UUID but it does offer support for
> > partition UUID.
> >
> > $ lsblk -o NAME,FSTYPE,UUID,PARTUUID
> > NAME   FSTYPE   UUID                                 PARTUUID
> > sda
> > |-sda1 vfat     6078-ACD0
> 95aa4ffb-741d-4d99-adf6-0358bc890046
> > |-sda2 squashfs
> 7d46da2d-29cc-4d5a-9e39-d0381c4abb0c
> > |-sda3 squashfs
> d4a3e24e-410a-4f2c-8ad5-8f8321de177b
> > |-sda4 ext4     d72ec529-78e4-4cd3-b39b-781b6b1cb47c
> f3edc990-f4f6-4536-9587-44dae4ceb99f
> > `-sda5 ext4     a0b265aa-e935-40b8-9c6b-e9e58ad3890f
> 6e72ebaa-29ed-41cd-844c-3f76976cf41d
> >
> > Removing this constrain allows a user to create squashfs-based rootfs
> and boot
> > from it with such kernel argument
> 'root=PARTUUID=7d46da2d-29cc-4d5a-9e39-d0381c4abb0c'
> >
> > Signed-off-by: Emmanuel Roullit <emmanuel.roullit at gmail.com>
>
> Please add in:
> Fixes: 2fbdcf4e59c8 ("wic: kparser.py: Check for SquashFS and use-uuid")
>
> > ---
> >  scripts/lib/wic/ksparser.py | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/scripts/lib/wic/ksparser.py b/scripts/lib/wic/ksparser.py
> > index e590b2f..92f0b6d 100644
> > --- a/scripts/lib/wic/ksparser.py
> > +++ b/scripts/lib/wic/ksparser.py
> > @@ -196,11 +196,6 @@ class KickStart():
> >                          raise KickStartError('%s:%d: %s' % \
> >                                               (confpath, lineno, err))
> >                      if line.startswith('part'):
> > -                        # SquashFS does not support UUID
> > -                        if parsed.fstype == 'squashfs' and
> parsed.use_uuid:
> > -                            err = "%s:%d: SquashFS does not support
> UUID" \
> > -                                  % (confpath, lineno)
> > -                            raise KickStartError(err)
> >                          # using ArgumentParser one cannot easily tell
> if option
> >                          # was passed as argument, if said option has a
> default
> >                          # value; --overhead-factor/--extra-space cannot
> be used
>
> So I got this logic slightly wrong then.  We should correct the check
> that we don't have parsed.fsuuid rather than use_uuid.  Thanks!
>
> --
> Tom
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180906/27738dff/attachment-0002.html>