[OE-core] [meta-oe][PATCH v2] minidlna: restore & fix recipe

Martin Jansa martin.jansa at gmail.com
Mon Sep 10 17:04:16 UTC 2018


And don't use tag name in SRCREV, use git SHA, so that bitbake fetcher
doesn't need to access the git repository every time it parses the recipe.

On Mon, Sep 10, 2018 at 5:49 PM Khem Raj <raj.khem at gmail.com> wrote:

> this should be in meta-multmedia layer.
> On Mon, Sep 10, 2018 at 8:15 AM Baptiste Durand
> <baptiste.durand at gmail.com> wrote:
> >
> > Restore minidlna recipe and bump it to v1.2.1
> >
> > Signed-off-by: Baptiste Durand <baptiste.durand at gmail.com>
> > ---
> >  .../recipes-multimedia/minidlna/minidlna.inc  | 41 +++++++++++++++++++
> >  .../0001-Update-Gettext-version.patch         | 34 +++++++++++++++
> >  .../minidlna/minidlna_1.2.1.bb                |  4 ++
> >  3 files changed, 79 insertions(+)
> >  create mode 100644 meta-oe/recipes-multimedia/minidlna/minidlna.inc
> >  create mode 100644
> meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch
> >  create mode 100644 meta-oe/recipes-multimedia/minidlna/
> minidlna_1.2.1.bb
> >
> > diff --git a/meta-oe/recipes-multimedia/minidlna/minidlna.inc
> b/meta-oe/recipes-multimedia/minidlna/minidlna.inc
> > new file mode 100644
> > index 000000000..187ff536a
> > --- /dev/null
> > +++ b/meta-oe/recipes-multimedia/minidlna/minidlna.inc
> > @@ -0,0 +1,41 @@
> > +DESCRIPTION = "MiniDLNA (aka ReadyDLNA) is server software with the aim
> of \
> > +being fully compliant with DLNA/UPnP-AV clients."
> > +LICENSE = "GPL-2.0|BSD"
> > +DEPENDS = "ffmpeg flac libav jpeg sqlite3 libexif libogg libid3tag
> libvorbis"
> > +
> > +# because it depends on libav which has commercial flag
> > +LICENSE_FLAGS = "commercial"
> > +
> > +inherit gettext autotools-brokensep update-rc.d systemd
> > +
> > +SRC_URI = "git://
> git.code.sf.net/p/minidlna/git;branch=master;module=git \
> > +           file://minidlna-daemon.init.d \
> > +           file://minidlna.service \
> > +           file://0001-Update-Gettext-version.patch \
> > +           "
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +# This remove "--exclude=autopoint" option from autoreconf argument to
> avoid
> > +# configure.ac:30: error: required file './ABOUT-NLS' not found
> > +EXTRA_AUTORECONF = ""
> > +
> > +do_install_append(){
> > +    install -d ${D}${sysconfdir}
> > +    install -m 0755 minidlna.conf ${D}${sysconfdir}
> > +
> > +# Systemd script
> > +    install -d ${D}${nonarch_base_libdir}/systemd/system
> > +    install -m 0755 ${WORKDIR}/minidlna.service
> ${D}${nonarch_base_libdir}/systemd/system
> > +
> > +# Sysvinit script
> > +    install -d ${D}${sysconfdir}/init.d
> > +    install -m 0755 ${WORKDIR}/minidlna-daemon.init.d
> ${D}${sysconfdir}/init.d/minidlna
> > +
> > +}
> > +
> > +SYSTEMD_SERVICE_${PN} = "minidlna.service"
> > +
> > +INITSCRIPT_NAME = "minidlna"
> > +INITSCRIPT_PARAMS = "defaults 90"
> > +
> > diff --git
> a/meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch
> b/meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch
> > new file mode 100644
> > index 000000000..c18095d42
> > --- /dev/null
> > +++
> b/meta-oe/recipes-multimedia/minidlna/minidlna/0001-Update-Gettext-version.patch
> > @@ -0,0 +1,34 @@
> > +From a4290bf1887f9203288858ca76bdd20b2edf337a Mon Sep 17 00:00:00 2001
> > +From: Baptiste Durand <baptiste.durand at gmail.com>
> > +Date: Sun, 9 Sep 2018 20:50:41 +0200
> > +Subject: [PATCH] Update Gettext version
> > +
> > +Upstream-Status: Inappropriate [oe-core specific]
> > +
> > +Signed-off-by: Baptiste Durand <baptiste.durand at gmail.com>
> > +---
> > + configure.ac | 4 ++--
> > + 1 file changed, 2 insertions(+), 2 deletions(-)
> > +
> > +diff --git a/configure.ac b/configure.ac
> > +index f343d21..a556b33 100644
> > +--- a/configure.ac
> > ++++ b/configure.ac
> > +@@ -14,7 +14,7 @@
> > + # License along with MiniDLNA; if not, write to the Free Software
> > + # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > + # USA.
> > +-AC_INIT(MiniDLNA,1.1.3,,minidlna)
> > ++AC_INIT(MiniDLNA,1.2.1,,minidlna)
> > + #LT_INIT
> > +
> > + AC_CANONICAL_TARGET
> > +@@ -28,7 +28,7 @@ m4_ifdef([AC_USE_SYSTEM_EXTENSIONS],
> [AC_USE_SYSTEM_EXTENSIONS])
> > +
> > + AM_ICONV
> > + AM_GNU_GETTEXT([external])
> > +-AM_GNU_GETTEXT_VERSION(0.18)
> > ++AM_GNU_GETTEXT_VERSION(0.19)
> > +
> > + # Checks for programs.
> > + AC_PROG_AWK
> > diff --git a/meta-oe/recipes-multimedia/minidlna/minidlna_1.2.1.bb
> b/meta-oe/recipes-multimedia/minidlna/minidlna_1.2.1.bb
> > new file mode 100644
> > index 000000000..fe6bebce2
> > --- /dev/null
> > +++ b/meta-oe/recipes-multimedia/minidlna/minidlna_1.2.1.bb
> > @@ -0,0 +1,4 @@
> > +require ${BPN}.inc
> > +
> > +SRCREV = "v1_2_1"
> > +LIC_FILES_CHKSUM =
> "file://LICENCE.miniupnpd;md5=b0dabf9d8e0f871554e309d62ead8d2b"
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20180910/a3ec1a86/attachment-0002.html>


More information about the Openembedded-core mailing list