[OE-core] [PATCH] libgloss_3.0.0.bb: Fix up mv pattern to include libnosys

Nathan Rossi nathan at nathanrossi.com
Tue Sep 11 08:28:20 UTC 2018


On Tue, 11 Sep 2018 at 02:19, Khem Raj <raj.khem at gmail.com> wrote:
>
> On Mon, Sep 10, 2018 at 5:43 AM Nathan Rossi <nathan at nathanrossi.com> wrote:
> >
> > When installing libgloss libraries handle the ${TARGET_SYS}/lib contents
> > so that it is placed in ${libdir} instead of ${libdir}/lib. This
> > resolves a packaging QA issue.
> >
> >   ERROR: libgloss-3.0.0-r0 do_package: QA Issue: libgloss:
> >   Files/directories were installed but not shipped in any package:
> >     /usr/lib/lib
> >     /usr/lib/lib/libnosys.a
> >     /usr/lib/lib/nosys.specs
> >   Please set FILES such that these items are packaged. Alternatively
> >   if they are unneeded, avoid installing them or delete them within
> >   do_install.
> >   libgloss: 3 installed and not shipped files. [installed-vs-shipped]
> >
> > Signed-off-by: Nathan Rossi <nathan at nathanrossi.com>
> > ---
> >  meta/recipes-core/newlib/libgloss_3.0.0.bb | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/newlib/libgloss_3.0.0.bb b/meta/recipes-core/newlib/libgloss_3.0.0.bb
> > index 664a922815..727062ca5d 100644
> > --- a/meta/recipes-core/newlib/libgloss_3.0.0.bb
> > +++ b/meta/recipes-core/newlib/libgloss_3.0.0.bb
> > @@ -18,9 +18,10 @@ do_install_prepend() {
> >
> >  do_install_append() {
> >         # Move libs to default directories so they can be picked up later
> > -       mv -v ${D}${prefix}/${TARGET_SYS}/lib ${D}${libdir}
> > +       mv -v ${D}${prefix}/${TARGET_SYS}/lib/* ${D}${libdir}
>
> seems to some indentation problem, please check.

Hmm, its all tabs (which is what the rest of the file is) and git-am
seems to apply without issues. What am I missing?

>
> >
> >         # Remove original directory
> > +       rmdir ${D}${prefix}/${TARGET_SYS}/lib
>
> maybe just use -p option above and remove the statement below

It looks like this patch was already merged into master. Should I send
another patch to change it to rmdir -p --ignore-fail-on-non-empty?

Thanks,
Nathan

>
> >         rmdir ${D}${prefix}/${TARGET_SYS}
> >  }
> >
> > ---
> > 2.18.0
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core



More information about the Openembedded-core mailing list