[OE-core] [PATCH v2] coreutils: add alternative target for nice

Jens Rehsack sno at netbsd.org
Wed Sep 12 20:30:42 UTC 2018


Tomorrow morning as first :)

2018-09-12 17:54 GMT+02:00 Martin Jansa <martin.jansa at gmail.com>:
> Still worn't work IMHO because you forgot to add nice.1 to
> ALTERNATIVE_${PN}-doc.
>
> Also the comment above bindir_progs:
> # [ df mktemp base64 gets a special treatment and is not included in this
> should probably be updated to include nice and remove nice from bindir_progs
>
> On Wed, Sep 12, 2018 at 2:02 PM Jens Rehsack <sno at netbsd.org> wrote:
>>
>> Avoid coreutils conflicts with nice from other recipes, like
>> busybox - even if that's not enabled by default.
>> In situations, where coreutils is a dependency for -dev images
>> and small busybox nice is available always, it avoids extra
>> effort for coreutils for those users.
>>
>> Signed-off-by: Jens Rehsack <sno at netbsd.org>
>> ---
>>  meta/recipes-core/coreutils/coreutils_8.30.bb | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/coreutils/coreutils_8.30.bb
>> b/meta/recipes-core/coreutils/coreutils_8.30.bb
>> index 053891f6ea..5ebd36026e 100644
>> --- a/meta/recipes-core/coreutils/coreutils_8.30.bb
>> +++ b/meta/recipes-core/coreutils/coreutils_8.30.bb
>> @@ -77,7 +77,7 @@ do_install_class-native() {
>>  }
>>
>>  do_install_append() {
>> -       for i in df mktemp base64; do mv ${D}${bindir}/$i
>> ${D}${bindir}/$i.${BPN}; done
>> +       for i in df mktemp nice base64; do mv ${D}${bindir}/$i
>> ${D}${bindir}/$i.${BPN}; done
>>
>>         install -d ${D}${base_bindir}
>>         [ "${base_bindir}" != "${bindir}" ] && for i in
>> ${base_bindir_progs}; do mv ${D}${bindir}/$i ${D}${base_bindir}/$i.${BPN};
>> done
>> @@ -113,6 +113,10 @@ ALTERNATIVE_LINK_NAME[df] = "${base_bindir}/df"
>>  ALTERNATIVE_TARGET[df] = "${bindir}/df.${BPN}"
>>  ALTERNATIVE_LINK_NAME[df.1] = "${mandir}/man1/df.1"
>>
>> +ALTERNATIVE_LINK_NAME[nice] = "${base_bindir}/nice"
>> +ALTERNATIVE_TARGET[nice] = "${bindir}/nice.${BPN}"
>> +ALTERNATIVE_LINK_NAME[nice.1] = "${mandir}/man1/nice.1"
>> +
>>  ALTERNATIVE_LINK_NAME[lbracket] = "${bindir}/["
>>  ALTERNATIVE_TARGET[lbracket] = "${bindir}/lbracket.${BPN}"
>>
>> --
>> 2.17.1
>>
>



More information about the Openembedded-core mailing list