[OE-core] [PATCH 08/10] os-release: fix install file conflict for multilib

[Kang Kai]

On 2018年09月29日 20:37, Richard Purdie wrote:
> On Sat, 2018-09-29 at 13:43 +0800, kai.kang at windriver.com wrote:
>> From: Kai Kang <kai.kang at windriver.com>
>>
>> It fails to create image when install os-release and lib32-os-release
>> both:
>>
>>> file /etc/os-release conflicts between attempted installs of
>>> os-release-1.0-r0.core2_64 and lib32-os-release-1.0-r0.x86
>> The /etc/os-release is a symlink link to ${libdir}/os-release.
>> Actually
>> the content of files are identical and make /etc/os-release to be
>> hard
>> link could fix the issue. But according to os-release (5), symlink
>> link
>> is necessary for initrd environment such as dracut.
>>
>> Signed-off-by: Kai Kang <kai.kang at windriver.com>
>> ---
>>   meta/recipes-core/os-release/os-release.bb | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/os-release/os-release.bb
>> b/meta/recipes-core/os-release/os-release.bb
>> index bf4f815a10..4d5487c06d 100644
>> --- a/meta/recipes-core/os-release/os-release.bb
>> +++ b/meta/recipes-core/os-release/os-release.bb
>> @@ -1,10 +1,12 @@
>> -inherit allarch
>> -
>>   SUMMARY = "Operating system identification"
>>   DESCRIPTION = "The /usr/lib/os-release file contains operating
>> system identification data."
>>   LICENSE = "MIT"
>>   INHIBIT_DEFAULT_DEPS = "1"
>>   
>> +inherit allarch multilib_script
>> +
>> +MULTILIB_SCRIPTS = "${PN}:${sysconfdir}/os-release"
> This is exactly the kind of thing I did not want to see
> MUTLILIB_SCRIPTS used for. Its now being proposed everywhere you have
> an issue with conflicting files without consideration about what
> actually makes sense.
>
> What might make more sense here is only to build os-release for the
> main namespace and not any of the multilibs. It could RPROVIDE if
> necessary.

Robert's patch about "multilib: avoid expanding grub and grub-efi to 
multilib' has been merged to master-next,
I'll do it base on his patch.

Regards,
Kai

>
> Cheers,
>
> Richard
>
>

-- 
Regards,
Neil | Kai Kang