[OE-core] [PATCH] cogl: fix compile error with -Werror=maybe-uninitialized
Adrian Bunk
bunk at stusta.de
Tue Apr 2 11:31:35 UTC 2019
On Tue, Apr 02, 2019 at 05:08:33PM +0800, changqing.li at windriver.com wrote:
> From: Changqing Li <changqing.li at windriver.com>
>
> fix below compile error with -Werror=maybe-uninitialized
>
> | ../../cogl-1.22.2/cogl/driver/gl/gles/cogl-driver-gles.c:217:17: error: 'gltype' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> | *out_gltype = gltype;
> | ~~~~~~~~~~~~^~~~~~~~
> | ../../cogl-1.22.2/cogl/driver/gl/gles/cogl-driver-gles.c:213:22: error: 'glintformat' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> | *out_glintformat = glintformat;
> | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
>...
Looking at the code, is this a failure that only happens with DEBUG_FLAGS?
> +--- a/cogl/driver/gl/gles/cogl-driver-gles.c
> ++++ b/cogl/driver/gl/gles/cogl-driver-gles.c
> +@@ -74,9 +74,9 @@ _cogl_driver_pixel_format_to_gl (CoglContext *context,
> + GLenum *out_gltype)
> + {
> + CoglPixelFormat required_format;
> +- GLenum glintformat;
> ++ GLenum glintformat = 0;
> + GLenum glformat = 0;
> +- GLenum gltype;
> ++ GLenum gltype = 0;
>...
Assigning random values to variables is a bug,
they do not even seem to be valid values for these variables.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
More information about the Openembedded-core
mailing list