[OE-core] [PATCH] insane.bbclass: fix QA-check to consider the PREFERRED_RPROVIDER for RDEPENDS

[Catalin Dan Udma]

Ping.

Thanks,
Catalin Udma

> -----Original Message-----
> From: Catalin Dan Udma
> Sent: Tuesday, March 5, 2019 3:36 PM
> To: Openembedded-core at lists.openembedded.org
> Cc: Catalin Dan Udma <catalin-dan.udma at nxp.com>
> Subject: [OE-core][PATCH] insane.bbclass: fix QA-check to consider the
> PREFERRED_RPROVIDER for RDEPENDS
> 
> QA-check looks in the RDEPENDS list without taking into consideration that a
> specific package may have a PREFERRED_RPROVIDER defined.
> If PREFERRED_RPROVIDER is set, QA-check will ignore that settings and will
> consider the original package, resulting in QA-check errors:
> 	ERROR: do_packate_qa: QA Issue: <...>, but no providers found in
> 	RDEPENDS_<package>? [file-rdeps]
> The fix is to replace the original package in the QA-check with the new
> package defined in PREFERRED_RPROVIDER, if it’s set.
> 
> Signed-off-by: Catalin Udma <catalin-dan.udma at nxp.com>
> ---
>  meta/classes/insane.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 6411884..165233b 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -689,6 +689,9 @@ def package_qa_check_rdepends(pkg, pkgdest, skip,
> taskdeps, packages, d):
>          # Now do the sanity check!!!
>          if "build-deps" not in skip:
>              for rdepend in rdepends:
> +                pref_rdepend = localdata.getVar("PREFERRED_RPROVIDER_%s" %
> rdepend)
> +                if pref_rdepend:
> +                    rdepend = pref_rdepend
>                  if "-dbg" in rdepend and "debug-deps" not in skip:
>                      error_msg = "%s rdepends on %s" % (pkg,rdepend)
>                      package_qa_handle_error("debug-deps", error_msg, d)
> @@ -739,6 +742,9 @@ def package_qa_check_rdepends(pkg, pkgdest, skip,
> taskdeps, packages, d):
>                  while next:
>                      new = []
>                      for rdep in next:
> +                        pref_rdep = localdata.getVar("PREFERRED_RPROVIDER_%s" %
> rdep)
> +                        if pref_rdep:
> +                            rdep = pref_rdep
>                          rdep_data = oe.packagedata.read_subpkgdata(rdep, d)
>                          sub_rdeps = rdep_data.get("RDEPENDS_" + rdep)
>                          if not sub_rdeps:
> --
> 2.7.4