[OE-core] [PATCH 13/13] gst-plugins: move 'inherit gobject-introspection' to recipes supporting GI

Alexander Kanavin alex.kanavin at gmail.com
Fri Apr 5 07:39:54 UTC 2019


Thanks, looks good!

Alex

> On 5 Apr 2019, at 8.37, Andreas Müller <schnitzeltony at gmail.com> wrote:
> 
> Now that whitelisting for unknown configure options was removed in
> gobject-introspection.bbclass gstreamer1.0-plugins-ugly/-good start complaining
> 
> | ERROR: gstreamer1.0-plugins-ugly-1.14.4-r0 do_configure: QA Issue: gstreamer1.0-plugins-ugly: configure was passed unrecognised options: --enable-introspection [unknown-configure-option]
> | ERROR: gstreamer1.0-plugins-good-1.14.4-r0 do_configure: QA Issue: gstreamer1.0-plugins-good: configure was passed unrecognised options: --enable-introspection [unknown-configure-option]
> 
> So let only those gst-plugin recipes inherit gobject-introspection whose sources
> support GI.
> 
> Signed-off-by: Andreas Müller <schnitzeltony at gmail.com>
> ---
> .../gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb                | 2 +-
> .../gstreamer/gstreamer1.0-plugins-base_1.14.4.bb               | 2 +-
> meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc      | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
> index 4987be865b..23d093d47c 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.4.bb
> @@ -20,7 +20,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=73a5855a8119deb017f5f13cf327095d \
> 
> DEPENDS += "gstreamer1.0-plugins-base"
> 
> -inherit gettext bluetooth
> +inherit gettext bluetooth gobject-introspection
> 
> PACKAGECONFIG ??= " \
>     ${GSTREAMER_ORC} \
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
> index 12c9bbce9d..f3e6daf564 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.4.bb
> @@ -28,7 +28,7 @@ S = "${WORKDIR}/gst-plugins-base-${PV}"
> 
> DEPENDS += "iso-codes util-linux"
> 
> -inherit gettext
> +inherit gettext gobject-introspection
> 
> PACKAGES_DYNAMIC =+ "^libgst.*"
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> index 5906e4ad36..bc24b05fec 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
> @@ -7,7 +7,7 @@ DEPENDS = "gstreamer1.0 glib-2.0-native"
> 
> SRC_URI_append = " file://gtk-doc-tweaks.patch"
> 
> -inherit autotools pkgconfig upstream-version-is-even gobject-introspection gtk-doc
> +inherit autotools pkgconfig upstream-version-is-even gtk-doc
> 
> acpaths = "-I ${S}/common/m4 -I ${S}/m4"
> 
> -- 
> 2.20.1
> 


More information about the Openembedded-core mailing list