[OE-core] [PATCH] gstreamer1.0-python: rework gobject-introspection handling

[Andreas Müller]

On Fri, Apr 5, 2019 at 10:05 PM Martin Jansa <martin.jansa at gmail.com> wrote:
>
> On Fri, Apr 05, 2019 at 09:28:35PM +0200, Andreas Müller wrote:
> > gobject-introspection is mandatory for gstreamer1.0-python - there is no
> > configure option to enable or disable it.
> >
> > To handle properly, this patch does:
> >
> > * Make 'gobject-introspection-data' a required distro feature
> > * Add
> >   'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
> >    - it was removed in gobject-introspection.bbclass to avoid
> >   | ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]
> >
> > Signed-off-by: Andreas Müller <schnitzeltony at gmail.com>
> > ---
> >  .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> > index 8d45ca2668..fb76a37b92 100644
> > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> > @@ -16,6 +16,10 @@ PNREAL = "gst-python"
> >
> >  S = "${WORKDIR}/${PNREAL}-${PV}"
> >
> > +# gobject-introspection is mandatory and cannot be configured
> > +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
>
> Is distro_features_check inherited somewhere? I don't see it in this
> part and the above IIRC doesn't work without distro_features_check
> inherit.
>
> Cheers,

At the time you wrote that V2 was prepared :)

I tend to forget that - need to check my meta-gnome patches for that...

Andreas