[OE-core] [PATCH 01/13] insane.bbclass: Trigger unrecognzed configure option for meson

[Khem Raj]

On Thu, Apr 4, 2019 at 11:38 PM Andreas Müller <schnitzeltony at gmail.com> wrote:
>
> Tested with 'unknown-configure-option' in ERROR_QA:
>
> For meson (glib-2.0-native):
> 1. add 'EXTRA_OEMESON_append = "-Dschnitzel=true -Dwurst=true"'
>    | ERROR: glib-2.0-native-1_2.58.3-r0 do_configure: QA Issue: glib-2.0-native: configure was passed unrecognised options: schnitzel wurst [unknown-configure-option]
> 2. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" schnitzel"'
>    | ERROR: glib-2.0-native-1_2.58.3-r0 do_configure: QA Issue: glib-2.0-native: configure was passed unrecognised options: wurst [unknown-configure-option]
> 3. change to 'UNKNOWN_CONFIGURE_WHITELIST_append=" schnitzel wurst"'
>    => builds without issues
>
> For autotools (readline-native):
> 1. add 'EXTRA_OECONF = "--with-schnitzel --with-wurst"'
>    | ERROR: readline-native-8.0-r0 do_configure: QA Issue: readline-native: configure was passed unrecognised options: --with-wurst --with-schnitzel [unknown-configure-option]
> 2. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" --with-schnitzel"'
>    | ERROR: readline-native-8.0-r0 do_configure: QA Issue: readline-native: configure was passed unrecognised options: --with-wurst [unknown-configure-option]
> 3. add 'UNKNOWN_CONFIGURE_WHITELIST_append=" --with-schnitzel --with-wurst"'
>    => builds without issues
>

thinking of Weisswurst with Bayerischer Süßer Senf
this patchset looks good :)


> Signed-off-by: Andreas Müller <schnitzeltony at gmail.com>
> ---
>
> This is a resend
>
>  meta/classes/insane.bbclass | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index 37b8bb0032..c8d18c07f5 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1093,12 +1093,16 @@ Rerun configure task after fixing this."""
>      ###########################################################################
>      # Check unrecognised configure options (with a white list)
>      ###########################################################################
> -    if bb.data.inherits_class("autotools", d):
> +    if bb.data.inherits_class("autotools", d) or bb.data.inherits_class("meson", d):
>          bb.note("Checking configure output for unrecognised options")
>          try:
> -            flag = "WARNING: unrecognized options:"
> -            log = os.path.join(d.getVar('B'), 'config.log')
> -            output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ')
> +            if bb.data.inherits_class("autotools", d):
> +                flag = "WARNING: unrecognized options:"
> +                log = os.path.join(d.getVar('B'), 'config.log')
> +            if bb.data.inherits_class("meson", d):
> +                flag = "WARNING: Unknown options:"
> +                log = os.path.join(d.getVar('T'), 'log.do_configure')
> +            output = subprocess.check_output(['grep', '-F', flag, log]).decode("utf-8").replace(', ', ' ').replace('"', '')
>              options = set()
>              for line in output.splitlines():
>                  options |= set(line.partition(flag)[2].split())
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core