[OE-core] [PATCH v2 1/4] update-alternatives.bbclass: Add function to get metadata

[Mariano Lopez]

On 4/7/19 4:32 PM, Richard Purdie wrote:
> On Sun, 2019-04-07 at 12:15 -0500, Mariano Lopez wrote:
>> -
>> -            # Default to generate shell script.. eventually we may want to change this...
>> -            alt_target = os.path.normpath(alt_target)
>> -
>> -            alt_setup_links  += '\tupdate-alternatives --install %s %s %s %s\n' % (alt_link, alt_name, alt_target, alt_priority)
>> -            alt_remove_links += '\tupdate-alternatives --remove  %s %s\n' % (alt_name, alt_target)
>> +        updates = update_alternatives_alt_targets(d, pkg)
>> +        for alt_name, alt_link, alt_target, alt_priority in updates:
>> +           alt_setup_links  += '\tupdate-alternatives --install %s %s %s %s\n' % (alt_link, alt_name, alt_target, alt_priority)
>> +           alt_remove_links += '\tupdate-alternatives --remove  %s %s\n' % (alt_name, alt_target)
> I think the above is three whitespaces, not four? I know its minor but
> it jumped out as I was comparing the code before/after!
>
> Cheers,
>
> Richard
>

Good catch! I have sent the the fixed version but I messed up with the 
cover letter, you can find the correct version here:
https://patchwork.openembedded.org/patch/160236/


I think I don't even need to put that link there :)

Thanks,

Mariano