[OE-core] [PATCH 1/1] runqemu: do not check return code of tput
Richard Purdie
richard.purdie at linuxfoundation.org
Thu Apr 11 20:25:03 UTC 2019
On Fri, 2019-01-25 at 11:18 +0800, Chen Qi wrote:
> The subprocess.run was replaced by subprocess.check_call because
> of compatibility support down to python 3.4. But we really don't
> care about whether that command succeeds. Some user reports that
> in some tmux environment, this command fails and gives some
> unpleasant traceback output. So we use 'call' instead of 'check_call'
> to avoid such problem.
>
> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> ---
> scripts/runqemu | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index c4a0ca8..d3239ee 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -1318,7 +1318,7 @@ def main():
> logger.info("SIGTERM received")
> os.kill(config.qemupid, signal.SIGTERM)
> config.cleanup()
> - subprocess.check_call(["tput", "smam"])
> + subprocess.call(["tput", "smam"])
> signal.signal(signal.SIGTERM, sigterm_handler)
>
> config.check_args()
> @@ -1340,7 +1340,7 @@ def main():
> return 1
> finally:
> config.cleanup()
> - subprocess.check_call(["tput", "smam"])
> + subprocess.call(["tput", "smam"])
Can you send a v2 with a comment saying we're ignoring errors
deliberately please? Otherwise someone will just "fix" this again.
Cheers,
Richard
More information about the Openembedded-core
mailing list