[OE-core] [PATCH] Revert "wic: Set a miniumum FAT16 volume size."

Angus Lees gus at inodes.org
Sat Apr 20 04:01:04 UTC 2019


ping?

On Thu, 21 Mar 2019 at 16:49, Angus Lees <gus at inodes.org> wrote:

> This reverts commit f7dfb4d43247d3c13a4e0a3853007d63b9512b83.
>
> FAT16 volumes do not have a minimum size of 8250 blocks
> (== slightly over 4MB).  Exhibit A: floppy disks.
>
> The original commit message suggests this was a workaround for a bug in
> parted - in which case we should fix it there, or use the wic
> `--fixed-size` option to pass down an enforced minimum from a more
> context-aware point in the callstack.
> ---
> (This should also be backported to sumo)
>
>  scripts/lib/wic/partition.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py
> index 3fe5c4e26c..2178321404 100644
> --- a/scripts/lib/wic/partition.py
> +++ b/scripts/lib/wic/partition.py
> @@ -322,7 +322,7 @@ class Partition():
>
>          dosfs_cmd = "mkdosfs %s -i %s %s %s -C %s %d" % \
>                      (label_str, self.fsuuid, size_str, extraopts, rootfs,
> -                     max(8250, rootfs_size))
> +                     rootfs_size)
>          exec_native_cmd(dosfs_cmd, native_sysroot)
>
>          mcopy_cmd = "mcopy -i %s -s %s/* ::/" % (rootfs, rootfs_dir)
> --
> 2.11.0
>
>

-- 
 - Gus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190420/7a58353d/attachment.html>


More information about the Openembedded-core mailing list