[OE-core] [PATCH] vte-native: reduce c++ requirements from c++17 -> c++11

[Andreas Müller]

On Mon, Apr 29, 2019 at 10:49 AM Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
>
> On Sat, 2019-04-27 at 13:37 +0200, Andreas Müller wrote:
> > This should fix build on ancient hosts
> >
> > Signed-off-by: Andreas Müller <schnitzeltony at gmail.com>
> > ---
> >  ...uce-gcc-required-support-downto-c-11.patch | 34 ++++++++++++++
> >  ...001-Revert-parser-glue-Use-std-clamp.patch | 44
> > +++++++++++++++++++
> >  ...replace-std-clamp-by-std-min-std-max.patch | 33 ++++++++++++++
> >  meta/recipes-support/vte/vte_0.56.1.bb        |  7 +++
> >  4 files changed, 118 insertions(+)
> >  create mode 100644 meta/recipes-support/vte/vte/0001-Reduce-gcc-
> > required-support-downto-c-11.patch
> >  create mode 100644 meta/recipes-support/vte/vte/0001-Revert-parser-
> > glue-Use-std-clamp.patch
> >  create mode 100644 meta/recipes-support/vte/vte/0001-vte.cc-replace-
> > std-clamp-by-std-min-std-max.patch
>
> Unfortunately it doesn't seem to be quite enough:
>
> https://autobuilder.yoctoproject.org/typhoon/api/v2/logs/461993/raw
> (from centos 7)
>
> | ../../vte-0.56.1/src/utf8-test.cc:27:22: error: ‘literals’ is not a
> namespace-name
> |  using namespace std::literals;
> |                       ^
>
> and:
>
> https://autobuilder.yoctoproject.org/typhoon/api/v2/logs/461960/raw
> (from debian9)
>
> | ../../vte-0.56.1/src/parser-cat.cc:140:31: error: enclosing class of
> constexpr non-static member function ‘bool PrettyPrinter::plain()
> const’ is not a literal type
> |          inline constexpr bool plain() const noexcept { return
> m_plain; }
> |                                ^~~~~
> | ../../vte-0.56.1/src/parser-cat.cc:134:7: note: ‘PrettyPrinter’ is
> not literal because:
> |  class PrettyPrinter {
> |        ^~~~~~~~~~~~~
>
> Unfortunately I merged the upgrade into master as we'd had green builds
> before this (chance meant we didn't hit this failure) so this is a more
> pressing problem now...
>
> Cheers,
>
> Richard
>
Understood - hope to find time till tomorrow for this. Need to find an
old machine for test because otherwise further fixes might remain
incomplete again.

Andreas