[OE-core] [PATCH] vte-native: reduce c++ requirements from c++17 -> c++11

[Bas Mevissen]

On 2019-04-29 15:47, Andreas Müller wrote:
> On Mon, Apr 29, 2019 at 2:21 PM Andreas Müller 
> <schnitzeltony at gmail.com> wrote:
>> 
>> On Mon, Apr 29, 2019 at 12:56 PM Bas Mevissen <abuse at basmevissen.nl> 
>> wrote:
>> >
>> > On 2019-04-29 11:29, Andreas Müller wrote:
>> >
>> > (...)
>> >
>> > >>
>> > > Understood - hope to find time till tomorrow for this. Need to find an
>> > > old machine for test because otherwise further fixes might remain
>> > > incomplete again.
>> > >
>> >
>> > Why not add the g++ option --std=c++11 when test building this recipe?
>> >
>> > $cat test.cc
>> >
>> > #include <string>
>> >
>> > using namespace std::literals;
>> >
>> > int main()
>> > {
>> >         return 0;
>> > }
>> >
>> >
>> > $ g++ --std=c++17 test.cc -o test
>> > $ g++ --std=c++11 test.cc -o test
>> > test.cc:5:22: error: ‘literals’ is not a namespace-name
>> >      5 | using namespace std::literals;
>> >        |                      ^~~~~~~~
>> >
>> > -- Bas.
>> Did that but on CFLAGS (copy & paste from another place in recipe) and
>> since issues popped up I thought it was right :(
>> 
> Looked into:
> 
> There is no easy way to get vte-native to build with c++11. Even if -
> patches possibly introduce functional changes/errors (and the result
> of oe-selftest is questionable with a massively patched vte).
> 
> So I see two ways to go:
> 
> 1. set vte-native requirements to c++14. That worked here with
> CXXFLAGS_append_class-native = " --std=c++14" but looking into logs of
> centos 7 there are several '--std=gnu++11'. Have no idea where they
> come from so chances are high this patch is going fail with c++14.

In Centos 7, its gcc-c++ is 4.8.5 currently. That version does not fully 
support c++14.

> 2. revert vte back to 0.52.2 and forget the idea to get recent
> gnome-terminal back in near future. That requires vte 0.56.1 and was
> the reason I sent the update here.
> 

vte 0.56.2 and 0.57 are out already. So better focus on one of those 
versions instead of 0.56.1.

> My preference is 2.
> 
> Cheers
> 
> Andreas