[OE-core] [OE-Core][PATCH v5 5/6] systemd-systemctl-native: simplify and support preset-all

Alex Kiernan alex.kiernan at gmail.com
Tue Apr 30 10:31:21 UTC 2019


On Mon, Apr 29, 2019 at 3:43 PM Alex Kiernan <alex.kiernan at gmail.com> wrote:
>
> From: Jonas Bonn <jonas at norrbonn.se>
>
> Now that the systemd class sets up service presets instead of actively
> enabling services, the 'enable' and 'disable' subcommands for systemctl
> are not actually used anywhere.  As such, we can remove these to make
> sure that nobody inadvertently introduces new uses of them.
>
> We do, however, one case where the enable/disable machinery is still
> required; that is for the read-only-rootfs case where the 'preset-all'
> command can not be called at runtime but needs to be called when creatng
> the image.  For this case, we implement 'preset-all' here.
>
> There was also a previous implement of 'preset'... not sure that this
> ever worked as the implementation looks bogus and there aren't any users
> anyway.  This patch removes the 'preset' subcommand, as well.
>
> Signed-off-by: Jonas Bonn <jonas at norrbonn.se>
> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>

So it turns out we need something more sophisticated for the read-only
rootfs case... assuming this series passes CI (and if it got applied),
it's still better than where we were, or I can split it in two, one
which addresses the machine-id changes and another for the read-only
root case.

I'm just rewriting systemctl-native in python and adding in handling
of preset files... the shell's gotten way too knarly!

-- 
Alex Kiernan


More information about the Openembedded-core mailing list