[OE-core] [OE-Core][master][PATCH] standard.py: Provide an additional option for devtool reset

[Mark Hatle]

On 8/8/19 3:27 PM, Alexander Kanavin wrote:
> For what it's worth I am firmly in the camp that finds the non-deletion of
> sources annoying. When I run 'devtool reset', there is never any unsaved work
> left in there, but I am in too much of a hurry to do the extra 'rm' on those
> sources, and so much later (sometimes months later) it has to be done just prior
> to starting work on something else entirely (but with the same upstream component).

May make sense to follow git as an example..

devtool reset does what it already does..

devtool reset --hard  also does the removal of the existing source.

But I've seen too many people blow away in progress source code without meaning
to.  Adding something like the --hard option would make it clear it's going to
all go away.

--Mark

> Alex
> 
> 
> On Thu, 8 Aug 2019 at 22:17, Manjukumar Harthikote Matha <MANJUKUM at xilinx.com
> <mailto:MANJUKUM at xilinx.com>> wrote:
> 
>     Hi Paul,
> 
>     > -----Original Message-----
>     > From: openembedded-core-bounces at lists.openembedded.org
>     <mailto:openembedded-core-bounces at lists.openembedded.org>
>     > <openembedded-core-bounces at lists.openembedded.org
>     <mailto:openembedded-core-bounces at lists.openembedded.org>> On Behalf Of
>     > Manjukumar Harthikote Matha
>     > Sent: Monday, March 4, 2019 3:27 PM
>     > To: Paul Eggleton <paul.eggleton at linux.intel.com
>     <mailto:paul.eggleton at linux.intel.com>>; openembedded-
>     > core at lists.openembedded.org <mailto:core at lists.openembedded.org>; Chandana
>     Kalluri <ckalluri at xilinx.com <mailto:ckalluri at xilinx.com>>
>     > Subject: Re: [OE-core] [OE-Core][master][PATCH] standard.py: Provide an
>     > additional option for devtool reset
>     >
>     > Hi Paul,
>     >
>     > > -----Original Message-----
>     > > From: openembedded-core-bounces at lists.openembedded.org
>     <mailto:openembedded-core-bounces at lists.openembedded.org>
>     > > [mailto:openembedded-core-bounces at lists.openembedded.org
>     <mailto:openembedded-core-bounces at lists.openembedded.org>] On Behalf Of
>     > > Paul Eggleton
>     > > Sent: Monday, March 04, 2019 12:17 PM
>     > > To: openembedded-core at lists.openembedded.org
>     <mailto:openembedded-core at lists.openembedded.org>; Chandana Kalluri
>     > > <ckalluri at xilinx.com <mailto:ckalluri at xilinx.com>>
>     > > Subject: Re: [OE-core] [OE-Core][master][PATCH] standard.py: Provide
>     > > an additional option for devtool reset
>     > >
>     > > On Friday, 8 February 2019 2:57:32 PM NZDT Sai Hari Chandana Kalluri wrote:
>     > > > The devtool reset command cleans the sysroot for a recipe in workspace.
>     > > > It also removes the append file but leaves the source code as in
>     > > > workspace. The source is not cleaned intentionally and the user has
>     > > > to manually remove it before calling devtool modify again.
>     > > >
>     > > > Provide the user with an option to remove the source code from
>     > > > workspace by adding a flag to the devtool reset command. The
>     > > > --rm-source option for the devtool reset command will also clean the
>     > > > source code from the workspace along with the sysroot and the append file.
>     > > > Ex: devtool reset --rm-source zip or devtool reset -r zip
>     > >
>     > > When I wrote this I made a conscious decision not to delete the
>     > > source, in case the user has unsaved work in the source tree; at least
>     > > then the user has to take an explicit step (an additional rm -rf) in
>     > > order to delete it. You might argue that adding an option is the same
>     > > as that explicit step, but I am still hesitant as you might for
>     > > example pick a previously used command from your command history with
>     > > -r in it and only realise after you've run it that you've just blown
>     away a bunch
>     > of your work.
>     > >
>     > > However, I have received the feedback from a number of people that
>     > > they find it annoying that they have to delete the source themselves
>     > > before being able to run devtool on the recipe again. I'd like to hear
>     > > from the wider community on the following two questions:
>     > >
>     > > 1) Does the convenience of having this kind of option outweigh the
>     > > potential danger of deleting unsaved work?
>     > >
>     > > 2) Are there issues that anyone is experiencing that force you to run
>     > > devtool clean/finish and then re-run devtool modify (or add, or
>     > > upgrade), making this kind of situation come up more frequently? Or is
>     > > it mostly that the source directories end up being left around to
>     stumble over
>     > some time later?
>     >
>     > We have seen source directories end up being left around (taking more disk
>     > space on certain projects), hence a solution to remove it might be
>     optimal. If the
>     > preference is not have "-r" option to avoid command history mistake, then
>     a full
>     > command like devtool reset --rm-source is acceptable as well
>     >
> 
> 
>     Any update on this?  Is there a reason not to merge this feature?
> 
>     Thanks,
>     Manju
>     -- 
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core at lists.openembedded.org
>     <mailto:Openembedded-core at lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
>